From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1602761714; x=1634297714; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=zmVfAZBQrTe6Fi17zOJ8O3GgbRp9oajUPFq1mfmh16w=; b=PrECu/k+7GIhTAXOQT5bcSsOkk740TxQHCmM/LjuSQb/SbacqqdBkhoS cVxnP8ABRNuMr/I1+/R+nLfU3cOIVyy1+d+eAYLKiu7TqR1YDIR7S8+zw jTKQxf9mRz1xSZuLW8VPTMMagol6C7z+XR0ORm1C51R+L3zr1+XLNouEs Pb8Xpf5DojjZiXilvFEuKr0LZclq3RhrFECmDFIUZBNEGNbYEBS52JAeh 7AIOtbvNDNfuFujYrpbk+bIArVMoVnNfEWVxY3W1sgNOKD9umz2pIyXc0 0wcZDRUPlwQGMPGydgSW46H5hD4JpAjd7BUUrwPK/aB90h2Wm3Ts1pU0p A==; Date: Thu, 15 Oct 2020 11:33:33 +0000 From: "henrik.bjoernlund@microchip.com" Message-ID: <20201015113333.6pbjvrib7kl7gczp@soft-test08> References: <20201012140428.2549163-1-henrik.bjoernlund@microchip.com> <20201012140428.2549163-10-henrik.bjoernlund@microchip.com> <1253ca825551235c5fd45300f401a161f2bdd3f2.camel@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1253ca825551235c5fd45300f401a161f2bdd3f2.camel@nvidia.com> Subject: Re: [Bridge] [PATCH net-next v5 09/10] bridge: cfm: Netlink GET status Interface. List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikolay Aleksandrov Cc: "netdev@vger.kernel.org" , "bridge@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "UNGLinuxDriver@microchip.com" , "idosch@mellanox.com" , "jiri@mellanox.com" , Roopa Prabhu , "kuba@kernel.org" , "horatiu.vultur@microchip.com" , "davem@davemloft.net" Thanks for your review. Regards Henrik The 10/14/2020 11:24, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, 2020-10-12 at 14:04 +0000, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink status > > get information interface. > > > > Add new nested netlink attributes. These attributes are used by the > > user space to get status information. > > > > GETLINK: > > Request filter RTEXT_FILTER_CFM_STATUS: > > Indicating that CFM status information must be delivered. > > > > IFLA_BRIDGE_CFM: > > Points to the CFM information. > > > > IFLA_BRIDGE_CFM_MEP_STATUS_INFO: > > This indicate that the MEP instance status are following. > > IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO: > > This indicate that the peer MEP status are following. > > > > CFM nested attribute has the following attributes in next level. > > > > GETLINK RTEXT_FILTER_CFM_STATUS: > > IFLA_BRIDGE_CFM_MEP_STATUS_INSTANCE: > > The MEP instance number of the delivered status. > > The type is u32. > > IFLA_BRIDGE_CFM_MEP_STATUS_OPCODE_UNEXP_SEEN: > > The MEP instance received CFM PDU with unexpected Opcode. > > The type is u32 (bool). > > IFLA_BRIDGE_CFM_MEP_STATUS_VERSION_UNEXP_SEEN: > > The MEP instance received CFM PDU with unexpected version. > > The type is u32 (bool). > > IFLA_BRIDGE_CFM_MEP_STATUS_RX_LEVEL_LOW_SEEN: > > The MEP instance received CCM PDU with MD level lower than > > configured level. This frame is discarded. > > The type is u32 (bool). > > > > IFLA_BRIDGE_CFM_CC_PEER_STATUS_INSTANCE: > > The MEP instance number of the delivered status. > > The type is u32. > > IFLA_BRIDGE_CFM_CC_PEER_STATUS_PEER_MEPID: > > The added Peer MEP ID of the delivered status. > > The type is u32. > > IFLA_BRIDGE_CFM_CC_PEER_STATUS_CCM_DEFECT: > > The CCM defect status. > > The type is u32 (bool). > > True means no CCM frame is received for 3.25 intervals. > > IFLA_BRIDGE_CFM_CC_CONFIG_EXP_INTERVAL. > > IFLA_BRIDGE_CFM_CC_PEER_STATUS_RDI: > > The last received CCM PDU RDI. > > The type is u32 (bool). > > IFLA_BRIDGE_CFM_CC_PEER_STATUS_PORT_TLV_VALUE: > > The last received CCM PDU Port Status TLV value field. > > The type is u8. > > IFLA_BRIDGE_CFM_CC_PEER_STATUS_IF_TLV_VALUE: > > The last received CCM PDU Interface Status TLV value field. > > The type is u8. > > IFLA_BRIDGE_CFM_CC_PEER_STATUS_SEEN: > > A CCM frame has been received from Peer MEP. > > The type is u32 (bool). > > This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. > > IFLA_BRIDGE_CFM_CC_PEER_STATUS_TLV_SEEN: > > A CCM frame with TLV has been received from Peer MEP. > > The type is u32 (bool). > > This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. > > IFLA_BRIDGE_CFM_CC_PEER_STATUS_SEQ_UNEXP_SEEN: > > A CCM frame with unexpected sequence number has been received > > from Peer MEP. > > The type is u32 (bool). > > When a sequence number is not one higher than previously received > > then it is unexpected. > > This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO. > > > > Signed-off-by: Henrik Bjoernlund > > Reviewed-by: Horatiu Vultur > > --- > > include/uapi/linux/if_bridge.h | 29 +++++++++ > > include/uapi/linux/rtnetlink.h | 1 + > > net/bridge/br_cfm_netlink.c | 105 +++++++++++++++++++++++++++++++++ > > net/bridge/br_netlink.c | 16 ++++- > > net/bridge/br_private.h | 6 ++ > > 5 files changed, 154 insertions(+), 3 deletions(-) > > > > > > Acked-by: Nikolay Aleksandrov > > -- /Henrik