From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 13 May 2021 15:34:24 +0200 From: Linus =?utf-8?Q?L=C3=BCssing?= Message-ID: <20210513133423.GB2222@otheros> References: <20210512231941.19211-1-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Bridge] [PATCH net-next v3 00/11] net: bridge: split IPv4/v6 mc router state and export for batman-adv List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikolay Aleksandrov Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Roopa Prabhu , Jakub Kicinski , "David S . Miller" On Thu, May 13, 2021 at 03:02:13PM +0300, Nikolay Aleksandrov wrote: > Nice work overall, thank you. I hope it was tested well. :) > It'd be great if later you could add some selftests. > > Cheers, > Nik Hi Nikolay, I think I found a way now to better deal with the protocol specific hlist_for_each_entry(), by using hlist_for_each() and a helper function, to reduce the duplicate code with br_{ip4,ip6}_multicast_get_rport_slot() as you suggested (and also removing duplicate code with br_{ip4,ip6}_multicast_mark_router()) and reworked patches 7 and 9 a bit for that... Sorry for the inconvience and my bad timing with your reviews. But thanks a lot for all your valuable feedback! Also netdevbpf patchwork had a few more remarks, they should hopefully be fixed now, too. Regards, Linus