From: Stephen Hemminger <stephen@networkplumber.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Nikolay Aleksandrov <razor@blackwall.org>,
bridge@lists.linux-foundation.org,
Nikolay Aleksandrov <nikolay@nvidia.com>,
roopa@nvidia.com, kuba@kernel.org, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero
Date: Wed, 20 Oct 2021 08:19:37 -0700 [thread overview]
Message-ID: <20211020081937.70059049@hermes.local> (raw)
In-Reply-To: <YW9qiUhDKT+56wkd@Laptop-X1>
On Wed, 20 Oct 2021 09:02:01 +0800
Hangbin Liu <liuhangbin@gmail.com> wrote:
> On Tue, Oct 19, 2021 at 07:09:42PM +0300, Nikolay Aleksandrov wrote:
> > > I started this patch when I saw there is not limit for setting
> > > multicast_membership_interval to 0, which will cause bridge remove the
> > > mdb directly after adding. Do you think this is a problem.
> > >
> > > And what about others? I don't think there is a meaning to set other intervals
> > > to 0.
> > >
> >
> > The problem is not if there is meaning, we cannot start restricting option values now after
> > they've become uapi (and have been for a very long time) because we can break user-space even
> > though chances are pretty low. I don't think this patch is acceptable, I commented on the other
> > patch issues but they don't matter because of this.
>
> OK, I got your mean, we should not restrict the configurations based on whether
> there is a meaning.
>
> Thanks
> Hangbin
Maybe the bridge command could enforce that the value set are sane relative
to the RFC? We already fixup some things in iproute2 utilities to workaround
places where changing defaults in kernel would break userspace.
next prev parent reply other threads:[~2021-10-20 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 8:26 [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero Hangbin Liu
2021-10-18 10:28 ` Nikolay Aleksandrov
2021-10-19 5:43 ` Hangbin Liu
2021-10-19 16:09 ` Nikolay Aleksandrov
2021-10-20 1:02 ` Hangbin Liu
2021-10-20 15:19 ` Stephen Hemminger [this message]
2021-10-21 1:08 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020081937.70059049@hermes.local \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=nikolay@nvidia.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox