From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 407778195D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1AAF4818B5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=bppXW6VDR+pb+O0s/GBMgHjeo0dyk4Z19CwR9nRdUqY=; b=I/dbdccpmFyof6NN2fUQMmS80Kye7WCB0cQOnWsCWr6kbYBSqsVNXYvpajN4WTXs5N PXhbKdVGq8qaZvgMB0u24QvcgieMU5sZBUZfzJF2amKkSCjUsiAOitoc/N3eYjx4+nbU UkvrRIvjsJnsPK6sjy/HtdP6xSLhmtUOAOXnyRclsyX3fiW0yb7AKTCDLDXVMQdlnFWk mil8xpZZTzvqkglqCqTqsMJxVx8FC4xg6utVXrjwvfOZdCzMwfSKP+sa1fb1IAQfgDPQ pESQws6EXy9LgJ4AVvyxftq7I/HfsvAzi5cWrDfXOlqoYDBtxh9cVpuCsIrL0Hca4ds+ PlOQ== Date: Sun, 11 Sep 2022 03:13:46 +0300 From: Vladimir Oltean Message-ID: <20220911001346.qno33l47i6nvgiwy@skbuf> References: <69db7606896c77924c11a6c175c4b1a6@kapio-technology.com> <5cee059b65f6f7671e099150f9da79c1@kapio-technology.com> <8dfc9b525f084fa5ad55019f4418a35e@kapio-technology.com> <20220908112044.czjh3xkzb4r27ohq@skbuf> <152c0ceadefbd742331c340bec2f50c0@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152c0ceadefbd742331c340bec2f50c0@kapio-technology.com> Subject: Re: [Bridge] [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: netdev@kapio-technology.com Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , linux-kselftest@vger.kernel.org, Shuah Khan , Ivan Vecera , Florian Fainelli , Daniel Borkmann , bridge@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, Ido Schimmel , kuba@kernel.org, Paolo Abeni , Vivien Didelot , Woojung Huh , Landen Chao , Sean Wang , Jiri Pirko , Christian Marangi , Hauke Mehrtens , Roopa Prabhu , DENG Qingfang , Claudiu Manoil , linux-mediatek@lists.infradead.org, Matthias Brugger , Yuwei Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, davem@davemloft.net On Fri, Sep 09, 2022 at 03:11:56PM +0200, netdev@kapio-technology.com wrote: > > > > On Wed, Sep 07, 2022 at 11:10:07PM +0200, netdev@kapio-technology.com wrote: > > > > > I am at the blackhole driver implementation now, as I suppose that the > > > > > iproute2 command should work with the mv88e6xxx driver when adding blackhole > > > > > entries (with a added selftest)? > > > > > I decided to add the blackhole feature as new ops for drivers with functions > > > > > blackhole_fdb_add() and blackhole_fdb_del(). Do you agree with that approach? > > > > > > > > I assume you are talking about extending 'dsa_switch_ops'? > > > > > > Yes, that is the idea. > > > > > > > If so, it's up to the DSA maintainers to decide. > > > > What will be the usefulness of adding a blackhole FDB entry from user > > space? > > With the software bridge it could be used to signal a untrusted host in > connection with a locked port entry attempt. I don't see so much use other > that test purposes with the driver though. Not a huge selling point, to be honest. Can't the blackhole flag remain settable only in the device -> bridge direction, with user space just reading it?