From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2DEB1401E1 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2BA8A40474 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X+gkU/NqbzBkggz5iJ5jkNMymmdjI88HmNgirY0p7mo=; b=TPiipjpDMk6wGWOJP+Agw+/0B6vH+/ztEW3I5tVyt2LoCYXke1TXQmFBwagKR/ECpK gEOm4H8c5qA8hZGz4VSJZPpkqt/IbvYZ19Te5+K8V6qcAjLW+yd00jruzQfGjWyTw1cr D5eAElpBXfz6xrI/19Get5d4/+bXbVvXDLrr4XJpc6KgZGXdlyBIfs1ftcluwlcs3TzI FPdNNA1X3wp1dFiIVzbhTRBNAtVDAHuEP77BPZNag0f6UGW/O85leK27nNsrOFr5A8gj BturwMnkyEbZpgiYOgFFYhxOalzV668fNDGJNiEqvHrmEQZIJTIN3mr4jmBQMU8LwU4k tOOg== Date: Thu, 20 Oct 2022 16:11:01 +0300 From: Vladimir Oltean Message-ID: <20221020131101.zotvyglhlayqdvu7@skbuf> References: <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-12-netdev@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221018165619.134535-12-netdev@kapio-technology.com> Subject: Re: [Bridge] [PATCH v8 net-next 11/12] net: dsa: mv88e6xxx: add blackhole ATU entries List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Hans J. Schultz" Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , linux-kselftest@vger.kernel.org, Joachim Wiberg , Shuah Khan , Ivan Vecera , Florian Fainelli , Daniel Borkmann , Ido Schimmel , bridge@lists.linux-foundation.org, Russell King , linux-arm-kernel@lists.infradead.org, Roopa Prabhu , kuba@kernel.org, Paolo Abeni , Vivien Didelot , Woojung Huh , Landen Chao , Jiri Pirko , Amit Cohen , Christian Marangi , Hauke Mehrtens , Hans Schultz , Sean Wang , DENG Qingfang , Claudiu Manoil , linux-mediatek@lists.infradead.org, Matthias Brugger , Yuwei Wang , Petr Machata , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Florent Fourcot , UNGLinuxDriver@microchip.com, davem@davemloft.net On Tue, Oct 18, 2022 at 06:56:18PM +0200, Hans J. Schultz wrote: > Blackhole FDB entries can now be added, deleted or replaced in the > driver ATU. Why is this necessary, why is it useful? > > Signed-off-by: Hans J. Schultz > --- > static int mv88e6xxx_port_fdb_add(struct dsa_switch *ds, int port, > const unsigned char *addr, u16 vid, > u16 fdb_flags, struct dsa_db db) > @@ -2742,9 +2794,10 @@ static int mv88e6xxx_port_fdb_add(struct dsa_switch *ds, int port, > struct mv88e6xxx_chip *chip = ds->priv; > int err; > > - /* Ignore entries with flags set */ > - if (fdb_flags) > + if (fdb_flags & DSA_FDB_FLAG_LOCKED) > return 0; I don't understand this. If no driver looks at DSA_FDB_FLAG_LOCKED (not even mv88e6xxx, up until the end of the series), then why was it propagated all the way in the first place? > + if (fdb_flags & DSA_FDB_FLAG_BLACKHOLE) > + return mv88e6xxx_blackhole_fdb_add(ds, addr, vid); > > if (mv88e6xxx_port_is_locked(chip, port)) > mv88e6xxx_atu_locked_entry_find_purge(ds, port, addr, vid); > @@ -2765,9 +2818,10 @@ static int mv88e6xxx_port_fdb_del(struct dsa_switch *ds, int port, > bool locked_found = false; > int err = 0; > > - /* Ignore entries with flags set */ > - if (fdb_flags) > + if (fdb_flags & DSA_FDB_FLAG_LOCKED) > return 0; > + if (fdb_flags & DSA_FDB_FLAG_BLACKHOLE) > + return mv88e6xxx_blackhole_fdb_del(ds, addr, vid); > > if (mv88e6xxx_port_is_locked(chip, port)) > locked_found = mv88e6xxx_atu_locked_entry_find_purge(ds, port, addr, vid); > -- > 2.34.1 >