From: Ido Schimmel <idosch@nvidia.com>
To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: mlxsw@nvidia.com, razor@blackwall.org,
Ido Schimmel <idosch@nvidia.com>,
edumazet@google.com, roopa@nvidia.com, kuba@kernel.org,
pabeni@redhat.com, davem@davemloft.net
Subject: [Bridge] [PATCH net-next v2 06/14] bridge: mcast: Expose __br_multicast_del_group_src()
Date: Sat, 10 Dec 2022 16:56:25 +0200 [thread overview]
Message-ID: <20221210145633.1328511-7-idosch@nvidia.com> (raw)
In-Reply-To: <20221210145633.1328511-1-idosch@nvidia.com>
Expose __br_multicast_del_group_src() which is symmetric to
br_multicast_new_group_src() and does not remove the installed {S, G}
forwarding entry, unlike br_multicast_del_group_src().
The function will be used in the error path when user space was able to
add a new source entry, but failed to install a corresponding forwarding
entry.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
---
Notes:
v1:
* New patch.
net/bridge/br_multicast.c | 11 ++++++++---
net/bridge/br_private.h | 1 +
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index b2bc23fdcee5..8432b4ea7f28 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -650,18 +650,23 @@ static void br_multicast_destroy_group_src(struct net_bridge_mcast_gc *gc)
kfree_rcu(src, rcu);
}
-void br_multicast_del_group_src(struct net_bridge_group_src *src,
- bool fastleave)
+void __br_multicast_del_group_src(struct net_bridge_group_src *src)
{
struct net_bridge *br = src->pg->key.port->br;
- br_multicast_fwd_src_remove(src, fastleave);
hlist_del_init_rcu(&src->node);
src->pg->src_ents--;
hlist_add_head(&src->mcast_gc.gc_node, &br->mcast_gc_list);
queue_work(system_long_wq, &br->mcast_gc_work);
}
+void br_multicast_del_group_src(struct net_bridge_group_src *src,
+ bool fastleave)
+{
+ br_multicast_fwd_src_remove(src, fastleave);
+ __br_multicast_del_group_src(src);
+}
+
static void br_multicast_destroy_port_group(struct net_bridge_mcast_gc *gc)
{
struct net_bridge_port_group *pg;
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 183de6c57d72..a3db99d79a3d 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -977,6 +977,7 @@ br_multicast_find_group_src(struct net_bridge_port_group *pg, struct br_ip *ip);
struct net_bridge_group_src *
br_multicast_new_group_src(struct net_bridge_port_group *pg,
struct br_ip *src_ip);
+void __br_multicast_del_group_src(struct net_bridge_group_src *src);
void br_multicast_del_group_src(struct net_bridge_group_src *src,
bool fastleave);
void br_multicast_ctx_init(struct net_bridge *br,
--
2.37.3
next prev parent reply other threads:[~2022-12-10 14:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 14:56 [Bridge] [PATCH net-next v2 00/14] bridge: mcast: Extensions for EVPN Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 01/14] bridge: mcast: Do not derive entry type from its filter mode Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 02/14] bridge: mcast: Split (*, G) and (S, G) addition into different functions Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 03/14] bridge: mcast: Place netlink policy before validation functions Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 04/14] bridge: mcast: Add a centralized error path Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 05/14] bridge: mcast: Expose br_multicast_new_group_src() Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel [this message]
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 07/14] bridge: mcast: Add a flag for user installed source entries Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 08/14] bridge: mcast: Avoid arming group timer when (S, G) corresponds to a source Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 09/14] bridge: mcast: Add support for (*, G) with a source list and filter mode Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 10/14] bridge: mcast: Allow user space to add " Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 11/14] bridge: mcast: Allow user space to specify MDB entry routing protocol Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 12/14] bridge: mcast: Support replacement of MDB port group entries Ido Schimmel
2022-12-11 9:26 ` Nikolay Aleksandrov
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 13/14] selftests: forwarding: Rename bridge_mdb test Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 14/14] selftests: forwarding: Add bridge MDB test Ido Schimmel
2022-12-12 23:40 ` [Bridge] [PATCH net-next v2 00/14] bridge: mcast: Extensions for EVPN patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221210145633.1328511-7-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox