From: Ido Schimmel <idosch@nvidia.com>
To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: petrm@nvidia.com, mlxsw@nvidia.com, razor@blackwall.org,
Ido Schimmel <idosch@nvidia.com>,
edumazet@google.com, roopa@nvidia.com, kuba@kernel.org,
pabeni@redhat.com, davem@davemloft.net
Subject: [Bridge] [PATCH net-next 2/4] bridge: mcast: Remove pointless sequence generation counter assignment
Date: Thu, 9 Feb 2023 09:18:50 +0200 [thread overview]
Message-ID: <20230209071852.613102-3-idosch@nvidia.com> (raw)
In-Reply-To: <20230209071852.613102-1-idosch@nvidia.com>
The purpose of the sequence generation counter in the netlink callback
is to identify if a multipart dump is consistent or not by calling
nl_dump_check_consistent() whenever a message is generated.
The function is not invoked by the MDB code, rendering the sequence
generation counter assignment pointless. Remove it.
Note that even if the function was invoked, we still could not
accurately determine if the dump is consistent or not, as there is no
sequence generation counter for MDB entries, unlike nexthop objects, for
example.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
net/bridge/br_mdb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index 13076206e497..96f36febfb30 100644
--- a/net/bridge/br_mdb.c
+++ b/net/bridge/br_mdb.c
@@ -421,8 +421,6 @@ static int br_mdb_dump(struct sk_buff *skb, struct netlink_callback *cb)
rcu_read_lock();
- cb->seq = net->dev_base_seq;
-
for_each_netdev_rcu(net, dev) {
if (netif_is_bridge_master(dev)) {
struct net_bridge *br = netdev_priv(dev);
--
2.37.3
next prev parent reply other threads:[~2023-02-09 7:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 7:18 [Bridge] [PATCH net-next 0/4] bridge: mcast: Preparations for VXLAN MDB Ido Schimmel
2023-02-09 7:18 ` [Bridge] [PATCH net-next 1/4] bridge: mcast: Use correct define in MDB dump Ido Schimmel
2023-02-09 8:18 ` Nikolay Aleksandrov
2023-02-09 7:18 ` Ido Schimmel [this message]
2023-02-09 8:19 ` [Bridge] [PATCH net-next 2/4] bridge: mcast: Remove pointless sequence generation counter assignment Nikolay Aleksandrov
2023-02-09 7:18 ` [Bridge] [PATCH net-next 3/4] bridge: mcast: Move validation to a policy Ido Schimmel
2023-02-09 8:23 ` Nikolay Aleksandrov
2023-02-11 3:20 ` Jakub Kicinski
2023-02-11 15:45 ` Ido Schimmel
2023-02-09 7:18 ` [Bridge] [PATCH net-next 4/4] selftests: forwarding: Add MDB dump test cases Ido Schimmel
2023-02-09 8:24 ` Nikolay Aleksandrov
2023-02-11 3:40 ` [Bridge] [PATCH net-next 0/4] bridge: mcast: Preparations for VXLAN MDB patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209071852.613102-3-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox