Ethernet Bridge development
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Johannes Nixdorf <jnixdorf-oss@avm.de>,
	netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
	bridge@lists.linux-foundation.org,
	Oleksij Rempel <linux@rempel-privat.de>,
	Eric Dumazet <edumazet@google.com>,
	Roopa Prabhu <roopa@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next 1/2] bridge: Add a limit on FDB entries
Date: Tue, 16 May 2023 13:44:28 +0300	[thread overview]
Message-ID: <20230516104428.i5ou4ogx7gt2x6gq@skbuf> (raw)
In-Reply-To: <ce3835d9-c093-cfcb-3687-3a375236cb8f@blackwall.org>

On Tue, May 16, 2023 at 01:32:05PM +0300, Nikolay Aleksandrov wrote:
> Let's take a step back, I wasn't suggesting we start with a full-fledged switchdev
> implementation. :) I meant only to see if the minimum global limit implementation
> suggested would suffice and would be able to later extend so switchdev can use and
> potentially modify (e.g. drivers setting limits etc). We can start with a simple
> support for limits and then extend accordingly. The important part here is to
> not add any uAPI that can't be changed later which would impact future changes.

I guess adding a global per-bridge learning limit now makes sense and
would not unreasonably hinder switchdev later on. The focus is on
"learning limit" and not a limit to user-created entries as Johannes has
currently done in v1. I don't necessarily see an urgent need for
IFLA_BR_FDB_CUR_ENTRIES, given the fact that user space can dump the FDB
and count what it needs, filtering for FDB types accordingly.

  reply	other threads:[~2023-05-16 10:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15  8:50 [Bridge] [PATCH net-next 1/2] bridge: Add a limit on FDB entries Johannes Nixdorf
2023-05-15  8:50 ` [Bridge] [PATCH net-next 2/2] bridge: Add a sysctl to limit new brides " Johannes Nixdorf
2023-05-15  9:35   ` Nikolay Aleksandrov
2023-05-15 11:27     ` Johannes Nixdorf
2023-05-16  8:27       ` Nikolay Aleksandrov
2023-05-15 15:56   ` Stephen Hemminger
2023-05-16  8:27     ` Johannes Nixdorf
2023-05-15  9:35 ` [Bridge] [PATCH net-next 1/2] bridge: Add a limit on " Nikolay Aleksandrov
2023-05-16  8:12   ` Johannes Nixdorf
2023-05-16  8:21     ` Nikolay Aleksandrov
2023-05-16  8:30     ` Nikolay Aleksandrov
2023-05-16  8:38 ` Nikolay Aleksandrov
2023-05-16  8:53   ` Johannes Nixdorf
2023-05-16  8:56     ` Nikolay Aleksandrov
2023-05-16 10:21       ` Vladimir Oltean
2023-05-16 10:32         ` Nikolay Aleksandrov
2023-05-16 10:44           ` Vladimir Oltean [this message]
2023-05-16 10:47             ` Nikolay Aleksandrov
2023-05-16 10:55               ` Vladimir Oltean
2023-05-16 11:04                 ` Nikolay Aleksandrov
2023-05-16 11:10                   ` Vladimir Oltean
2023-05-16 11:18                     ` Nikolay Aleksandrov
2023-05-26  8:37                       ` Johannes Nixdorf
  -- strict thread matches above, loose matches on Subject: below --
2023-10-19 15:39 Scott Wadkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230516104428.i5ou4ogx7gt2x6gq@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@nvidia.com \
    --cc=jnixdorf-oss@avm.de \
    --cc=kuba@kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox