From: Amit Cohen <amcohen@nvidia.com>
To: netdev@vger.kernel.org
Cc: Petr Machata <petrm@nvidia.com>,
razor@blackwall.org, Amit Cohen <amcohen@nvidia.com>,
mlxsw@nvidia.com, dsahern@kernel.org,
bridge@lists.linux-foundation.org, idosch@nvidia.com,
linux-kselftest@vger.kernel.org, roopa@nvidia.com,
kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org,
davem@davemloft.net
Subject: [Bridge] [PATCH net-next 02/11] vxlan: vxlan_core: Make vxlan_flush() more generic for future use
Date: Mon, 9 Oct 2023 13:06:09 +0300 [thread overview]
Message-ID: <20231009100618.2911374-3-amcohen@nvidia.com> (raw)
In-Reply-To: <20231009100618.2911374-1-amcohen@nvidia.com>
The function vxlan_flush() gets a boolean called 'do_all' and in case
that it is false, it does not flush entries with state 'NUD_PERMANENT'
or 'NUD_NOARP'. The following patches will add support for FDB flush
with parameters from user space. Make the function more generic, so it
can be used later.
Signed-off-by: Amit Cohen <amcohen@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
---
drivers/net/vxlan/vxlan_core.c | 30 ++++++++++++++++++++++++++----
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index 5b5597073b00..1c58fddb7df4 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -3022,8 +3022,23 @@ static int vxlan_open(struct net_device *dev)
return ret;
}
+struct vxlan_fdb_flush_desc {
+ unsigned long state;
+ unsigned long state_mask;
+};
+
+static bool vxlan_fdb_flush_matches(const struct vxlan_fdb *f,
+ const struct vxlan_fdb_flush_desc *desc)
+{
+ if (desc->state_mask && (f->state & desc->state_mask) != desc->state)
+ return false;
+
+ return true;
+}
+
/* Purge the forwarding table */
-static void vxlan_flush(struct vxlan_dev *vxlan, bool do_all)
+static void vxlan_flush(struct vxlan_dev *vxlan,
+ const struct vxlan_fdb_flush_desc *desc)
{
unsigned int h;
@@ -3034,8 +3049,10 @@ static void vxlan_flush(struct vxlan_dev *vxlan, bool do_all)
hlist_for_each_safe(p, n, &vxlan->fdb_head[h]) {
struct vxlan_fdb *f
= container_of(p, struct vxlan_fdb, hlist);
- if (!do_all && (f->state & (NUD_PERMANENT | NUD_NOARP)))
+
+ if (!vxlan_fdb_flush_matches(f, desc))
continue;
+
/* the all_zeros_mac entry is deleted at vxlan_uninit */
if (is_zero_ether_addr(f->eth_addr) &&
f->vni == vxlan->cfg.vni)
@@ -3050,12 +3067,16 @@ static void vxlan_flush(struct vxlan_dev *vxlan, bool do_all)
static int vxlan_stop(struct net_device *dev)
{
struct vxlan_dev *vxlan = netdev_priv(dev);
+ struct vxlan_fdb_flush_desc desc = {
+ .state = 0,
+ .state_mask = NUD_PERMANENT | NUD_NOARP,
+ };
vxlan_multicast_leave(vxlan);
del_timer_sync(&vxlan->age_timer);
- vxlan_flush(vxlan, false);
+ vxlan_flush(vxlan, &desc);
vxlan_sock_release(vxlan);
return 0;
@@ -4294,8 +4315,9 @@ static int vxlan_changelink(struct net_device *dev, struct nlattr *tb[],
static void vxlan_dellink(struct net_device *dev, struct list_head *head)
{
struct vxlan_dev *vxlan = netdev_priv(dev);
+ struct vxlan_fdb_flush_desc desc = {};
- vxlan_flush(vxlan, true);
+ vxlan_flush(vxlan, &desc);
list_del(&vxlan->next);
unregister_netdevice_queue(dev, head);
--
2.40.1
next prev parent reply other threads:[~2023-10-09 10:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 10:06 [Bridge] [PATCH net-next 00/11] Extend VXLAN driver to support FDB flushing Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 01/11] net: Handle bulk delete policy in bridge driver Amit Cohen
2023-10-09 10:06 ` Amit Cohen [this message]
2023-10-09 10:06 ` [Bridge] [PATCH net-next 03/11] vxlan: vxlan_core: Do not skip default entry in vxlan_flush() by default Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 04/11] vxlan: vxlan_core: Add support for FDB flush Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 05/11] vxlan: vxlan_core: Support FDB flushing by source VNI Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 06/11] vxlan: vxlan_core: Support FDB flushing by nexthop ID Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 07/11] vxlan: vxlan_core: Support FDB flushing by destination VNI Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 08/11] vxlan: vxlan_core: Support FDB flushing by destination port Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 09/11] vxlan: vxlan_core: Support FDB flushing by destination IP Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 10/11] selftests: Add test cases for FDB flush with VXLAN device Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 11/11] selftests: fdb_flush: Add test cases for FDB flush with bridge device Amit Cohen
2023-10-10 19:11 ` Scott Wadkins
2023-10-10 18:50 ` [Bridge] [PATCH net-next 00/11] Extend VXLAN driver to support FDB flushing Nikolay Aleksandrov
2023-10-13 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009100618.2911374-3-amcohen@nvidia.com \
--to=amcohen@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox