From: Ido Schimmel <idosch@nvidia.com>
To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: mlxsw@nvidia.com, razor@blackwall.org,
Ido Schimmel <idosch@nvidia.com>,
edumazet@google.com, roopa@nvidia.com, kuba@kernel.org,
pabeni@redhat.com, davem@davemloft.net
Subject: [Bridge] [PATCH net-next v2 05/13] vxlan: mdb: Adjust function arguments
Date: Wed, 25 Oct 2023 15:30:12 +0300 [thread overview]
Message-ID: <20231025123020.788710-6-idosch@nvidia.com> (raw)
In-Reply-To: <20231025123020.788710-1-idosch@nvidia.com>
Adjust the function's arguments and rename it to allow it to be reused
by future call sites that only have access to 'struct
vxlan_mdb_entry_key', but not to 'struct vxlan_mdb_config'.
No functional changes intended.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
---
drivers/net/vxlan/vxlan_mdb.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/vxlan/vxlan_mdb.c b/drivers/net/vxlan/vxlan_mdb.c
index 5e041622261a..0b6043e1473b 100644
--- a/drivers/net/vxlan/vxlan_mdb.c
+++ b/drivers/net/vxlan/vxlan_mdb.c
@@ -370,12 +370,10 @@ static bool vxlan_mdb_is_valid_source(const struct nlattr *attr, __be16 proto,
return true;
}
-static void vxlan_mdb_config_group_set(struct vxlan_mdb_config *cfg,
- const struct br_mdb_entry *entry,
- const struct nlattr *source_attr)
+static void vxlan_mdb_group_set(struct vxlan_mdb_entry_key *group,
+ const struct br_mdb_entry *entry,
+ const struct nlattr *source_attr)
{
- struct vxlan_mdb_entry_key *group = &cfg->group;
-
switch (entry->addr.proto) {
case htons(ETH_P_IP):
group->dst.sa.sa_family = AF_INET;
@@ -503,7 +501,7 @@ static int vxlan_mdb_config_attrs_init(struct vxlan_mdb_config *cfg,
entry->addr.proto, extack))
return -EINVAL;
- vxlan_mdb_config_group_set(cfg, entry, mdbe_attrs[MDBE_ATTR_SOURCE]);
+ vxlan_mdb_group_set(&cfg->group, entry, mdbe_attrs[MDBE_ATTR_SOURCE]);
/* rtnetlink code only validates that IPv4 group address is
* multicast.
--
2.40.1
next prev parent reply other threads:[~2023-10-25 12:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 12:30 [Bridge] [PATCH net-next v2 00/13] Add MDB get support Ido Schimmel
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 01/13] bridge: mcast: Dump MDB entries even when snooping is disabled Ido Schimmel
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 02/13] bridge: mcast: Account for missing attributes Ido Schimmel
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 03/13] bridge: mcast: Factor out a helper for PG entry size calculation Ido Schimmel
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 04/13] bridge: mcast: Rename MDB entry get function Ido Schimmel
2023-10-25 12:30 ` Ido Schimmel [this message]
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 06/13] vxlan: mdb: Factor out a helper for remote entry size calculation Ido Schimmel
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 07/13] bridge: add MDB get uAPI attributes Ido Schimmel
2023-10-26 6:22 ` Nikolay Aleksandrov
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 08/13] net: Add MDB get device operation Ido Schimmel
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 09/13] bridge: mcast: Add MDB get support Ido Schimmel
2023-10-26 6:23 ` Nikolay Aleksandrov
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 10/13] vxlan: mdb: " Ido Schimmel
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 11/13] rtnetlink: " Ido Schimmel
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 12/13] selftests: bridge_mdb: Use MDB get instead of dump Ido Schimmel
2023-10-25 12:30 ` [Bridge] [PATCH net-next v2 13/13] selftests: vxlan_mdb: " Ido Schimmel
2023-10-27 10:00 ` [Bridge] [PATCH net-next v2 00/13] Add MDB get support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025123020.788710-6-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox