From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 888C22206B8 for ; Tue, 11 Feb 2025 13:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739280520; cv=none; b=DJUzRV0MJ06cyIzS1LbZz1OXRxqrJnAMgaDAUBdlbnYFUG3w+v/AG6K2cz8x1mD99qXm1o0o+LrHj56sleB07ZU6CzzCTWXasIl+pvqfWN1Y3Kzz+gCWMI4RFrHHq9IlUdnOT7JqueIBGKcXM05Gq9eIsSdWn7qKJdA/6N5Ut4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739280520; c=relaxed/simple; bh=J36o2DjG9YjX+05Z3jhO/S9Q8yTRO0ZZ92yOnlQxnuE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NKqw07F6+uB3vwVtnEC9BsYQcORxkYwOKNMKhQf4dfT5rKvwLKUElY5Xs+0UFT0MMAJVMrd/7Rf1joC+8ALShMzAgJS3Yi51b92v9hfE4TE35MGxpg0lgSP1F0ZJE1vC/zOEipovFRduzPwTLHQSLnnB8zlfgT71jGUA8+K0b+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nr+lWYRj; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nr+lWYRj" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ab7e08f56a0so8810466b.1 for ; Tue, 11 Feb 2025 05:28:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739280517; x=1739885317; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WLyb+sxmlUWI3PPRd+G753tkjaglzT6ouXpQ3N3NRPQ=; b=Nr+lWYRjcjzk8rMlRw6/VTYpOCArxKRayHScAwGB2Vu34Mw8FKz/Nf0Jr/9YDgKLkt Yu2RI/GVcCRHocKP3wfNf25ZmsKfHqWGnMZOjok6M1UPbw0zkaoakE+nE0wNQ+T1jE6Z 9lUnbQjkUoiDTa40Kct56PD+8uBWgnh6AvtsHeq4S5MSqyA58PbAmlvG1sjs309pnVtO 00w21fTbm1suiwUYzhuhzDbQ5PyPMA294TPZg8EFfpc5/R601LI2w2knqeSBMY+tbO3N 5j2kbwC9P93r3qi7YFP5RInXIJXRb8T5euiwK3ca/cgnOa2Qv9w/8Sa9/FER8/57rnKZ 70Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739280517; x=1739885317; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WLyb+sxmlUWI3PPRd+G753tkjaglzT6ouXpQ3N3NRPQ=; b=GpuJUUbzH+HYPyjEl9hCKXzglZgWrRiwVY+vjENMF0xy1QhzIIVV8UD5cGh+yolwEl rVqNvIQbmkamEteLVrhIyQUrZRLym7Ih8oFO2U20ROjvrjjiD6dZiitnHdLrv9DWqhXM tVyr9UrSxCZgYNYE83R3dkBt4FCAfNTUW3nN6ZFRXMti89dLhLNzJU6hajMKVrxaWcn8 8Ds7WPZGlDRBIMnF0nY110Uuy0byVu/ttxEYwfVuFJJwo+FP99HFnsHcFGl8T9Ys4RBv ldM2I1uhFh4fDfY2Vf0QD/mERQHJu147g07ww+Y4Q4RWIbHrcfE+FFPgx1CN/lhYw/sB YMWQ== X-Forwarded-Encrypted: i=1; AJvYcCX6GxDE1KCNR2U1+LalLRCjaev7/fQLPQBQ7BcQk4VrOjhGCdyaG2g2sq3sb+OacCeutt1pWCI=@lists.linux.dev X-Gm-Message-State: AOJu0YyZ2joWD2erSruotDddC99oIbJk4jYvOxu0AHkCxeC9zG2w2civ EMZHFiaVZNXJgV7u0FzQCyK5COlWQaYsR3/jCULGBSYFpeJkFp5d X-Gm-Gg: ASbGncvi2xSGnUhOQ7MSWWS6mv93TogRD9SXobdFcTRzgSy3TGvt0fkbnSZxzqBKACG UNJSebvvA90EBfcPhjmH9BFFxHnzrKnudi6eysUfqphpfGQ6vLOz+/LD+vp9OhsML0fBWvOxTQw ysYGN4x3Rq+Gh/I9yWExR/Exjk96mC2U5MuKKBI+JHbWfJv604iMKFEzg8kZlI068ZUOOLYtJOT TKXSMB3Sx7dtDKoKjDL0YURoDbO9ncT4J3A+c5f8k/wCAebqNgTSQz+0p+Xz0gTqTmNbCXnG+2q 31Q= X-Google-Smtp-Source: AGHT+IEI3sHUVuDg9ehqKY+KygjpcwX0rbXlLEswHpVnNf7eTh4qQELv+eql57rgOrrbLVr2hu6FNg== X-Received: by 2002:a17:907:7d87:b0:ab7:cd83:98bb with SMTP id a640c23a62f3a-ab7e0e6e245mr105887066b.5.1739280516517; Tue, 11 Feb 2025 05:28:36 -0800 (PST) Received: from skbuf ([86.127.124.81]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7dca728fcsm147341966b.166.2025.02.11.05.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 05:28:35 -0800 (PST) Date: Tue, 11 Feb 2025 15:28:32 +0200 From: Vladimir Oltean To: Eric Woudstra Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , Pablo Neira Ayuso , Jozsef Kadlecsik , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Matthias Brugger , AngeloGioacchino Del Regno , Kuniyuki Iwashima , Sebastian Andrzej Siewior , Lorenzo Bianconi , Joe Damato , Alexander Lobakin , Frank Wunderlich , Daniel Golle , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v6 net-next 05/14] bridge: Add filling forward path from port to port Message-ID: <20250211132832.aiy6ocvqppoqkd65@skbuf> References: <20250209111034.241571-1-ericwouds@gmail.com> <20250209111034.241571-6-ericwouds@gmail.com> Precedence: bulk X-Mailing-List: bridge@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250209111034.241571-6-ericwouds@gmail.com> On Sun, Feb 09, 2025 at 12:10:25PM +0100, Eric Woudstra wrote: > @@ -1453,7 +1454,10 @@ void br_vlan_fill_forward_path_pvid(struct net_bridge *br, > if (!br_opt_get(br, BROPT_VLAN_ENABLED)) > return; > > - vg = br_vlan_group(br); > + if (p) > + vg = nbp_vlan_group(p); > + else > + vg = br_vlan_group(br); > > if (idx >= 0 && > ctx->vlan[idx].proto == br->vlan_proto) { I think the original usage of br_vlan_group() here was incorrect, and so is the new usage of nbp_vlan_group(). They should be br_vlan_group_rcu() and nbp_vlan_group_rcu(). The lockdep annotation is important, otherwise I get this with CONFIG_PROVE_LOCKING=y: [ 1140.931869] ============================= [ 1140.935996] WARNING: suspicious RCU usage [ 1140.940094] 6.14.0-rc1-00224-gda8926a49ba1-dirty #2666 Not tainted [ 1140.946371] ----------------------------- [ 1140.950520] net/bridge/br_private.h:1604 suspicious rcu_dereference_protected() usage! [ 1140.958622] [ 1140.958622] other info that might help us debug this: [ 1140.958622] [ 1140.966752] [ 1140.966752] rcu_scheduler_active = 2, debug_locks = 1 [ 1140.973435] 2 locks held by swapper/0/0: [ 1140.977521] #0: ffffd9f646c333b0 (rcu_read_lock){....}-{1:3}, at: rcu_lock_acquire+0x4/0x40 [ 1140.986404] #1: ffffd9f646c333b0 (rcu_read_lock){....}-{1:3}, at: rcu_lock_acquire+0x4/0x48 [ 1140.995170] [ 1140.995170] stack backtrace: [ 1140.999636] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.14.0-rc1-00224-gda8926a49ba1-dirty #2666 [ 1140.999650] Hardware name: LS1028A RDB Board (DT) [ 1140.999656] Call trace: [ 1140.999660] show_stack+0x24/0x38 (C) [ 1140.999683] dump_stack_lvl+0x40/0xa0 [ 1140.999698] dump_stack+0x18/0x24 [ 1140.999711] lockdep_rcu_suspicious+0x174/0x218 [ 1140.999723] br_vlan_fill_forward_path_pvid+0x90/0x150 [ 1140.999735] br_fill_forward_path+0x54/0x1b0 [ 1140.999751] dev_fill_bridge_path+0x9c/0x188 [ 1140.999766] nft_dev_fill_bridge_path+0x2ac/0x418 [ 1140.999785] nft_flow_offload_bridge_init+0x188/0x1c8 [ 1140.999801] nft_flow_offload_eval+0x18c/0x300 [ 1140.999816] nft_do_chain+0x1c8/0x538 [ 1140.999831] nft_do_chain_bridge+0x15c/0x210 [ 1140.999846] nf_hook_slow+0x80/0x130 [ 1140.999862] NF_HOOK+0xd8/0x1d0 [ 1140.999871] __br_forward+0x138/0x1a0 [ 1140.999880] br_forward+0xd8/0x160 [ 1140.999889] br_handle_frame_finish+0x3bc/0x5a8 [ 1140.999900] br_nf_pre_routing_finish+0x538/0x608 [ 1140.999917] NF_HOOK+0x254/0x298 [ 1140.999933] br_nf_pre_routing+0x3e8/0x428 [ 1140.999949] br_handle_frame+0x264/0x490 [ 1140.999959] __netif_receive_skb_core+0x13c/0x1128 [ 1140.999975] __netif_receive_skb_list_core+0xd4/0x1e8 [ 1140.999989] netif_receive_skb_list_internal+0x224/0x338 [ 1141.000000] napi_complete_done+0xb4/0x1d8 [ 1141.000012] gro_cell_poll+0x94/0xb8 [ 1141.000025] __napi_poll+0x58/0x258 [ 1141.000040] net_rx_action+0x1f4/0x3e0 [ 1141.000055] handle_softirqs+0x184/0x458 [ 1141.000070] __do_softirq+0x20/0x2c [ 1141.000079] ____do_softirq+0x1c/0x30 [ 1141.000095] call_on_irq_stack+0x24/0x58 [ 1141.000111] do_softirq_own_stack+0x28/0x40 [ 1141.000127] __irq_exit_rcu+0xd4/0x1a0 [ 1141.000139] irq_exit_rcu+0x1c/0x40 [ 1141.000152] el1_interrupt+0x8c/0xc0 [ 1141.000170] el1h_64_irq_handler+0x18/0x28 [ 1141.000186] el1h_64_irq+0x6c/0x70 [ 1141.000195] arch_local_irq_enable+0x8/0x10 (P) [ 1141.000213] cpuidle_enter+0x44/0x68 [ 1141.000228] do_idle+0x1e8/0x280 [ 1141.000238] cpu_startup_entry+0x40/0x50 [ 1141.000248] rest_init+0x1c4/0x1d0 [ 1141.000260] start_kernel+0x324/0x3e8 [ 1141.000272] __primary_switched+0x88/0x98 [ 1141.197568] ------------[ cut here ]------------