From: Jakub Kicinski <kuba@kernel.org>
To: Joseph Huang <Joseph.Huang@garmin.com>
Cc: <netdev@vger.kernel.org>,
Joseph Huang <joseph.huang.2024@gmail.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
Roopa Prabhu <roopa@nvidia.com>, Simon Horman <horms@kernel.org>,
<linux-kernel@vger.kernel.org>, <bridge@lists.linux.dev>
Subject: Re: [Patch v4 net-next 1/3] net: bridge: mcast: Add offload failed mdb flag
Date: Thu, 10 Apr 2025 20:13:41 -0700 [thread overview]
Message-ID: <20250410201341.17660e10@kernel.org> (raw)
In-Reply-To: <20250408154116.3032467-2-Joseph.Huang@garmin.com>
On Tue, 8 Apr 2025 11:41:09 -0400 Joseph Huang wrote:
> - if (err)
> - goto err;
> + if (err == -EOPNOTSUPP)
> + goto notsupp;
>
> spin_lock_bh(&br->multicast_lock);
> mp = br_mdb_ip_get(br, &data->ip);
> @@ -516,11 +516,12 @@ static void br_switchdev_mdb_complete(struct net_device *dev, int err, void *pri
> pp = &p->next) {
> if (p->key.port != port)
> continue;
> - p->flags |= MDB_PG_FLAGS_OFFLOAD;
> +
> + br_multicast_set_pg_offload_flags(p, !err);
> }
> out:
> spin_unlock_bh(&br->multicast_lock);
> -err:
> +notsupp:
One small nit, please name the jump label after the target,
not the reason for the jump. So here "out_free" would be
a good name.
> kfree(priv);
next prev parent reply other threads:[~2025-04-11 3:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 15:41 [Patch v4 net-next 0/3] Add support for mdb offload failure notification Joseph Huang
2025-04-08 15:41 ` [Patch v4 net-next 1/3] net: bridge: mcast: Add offload failed mdb flag Joseph Huang
2025-04-11 3:13 ` Jakub Kicinski [this message]
2025-04-08 15:41 ` [Patch v4 net-next 2/3] net: bridge: Add offload_fail_notification bopt Joseph Huang
2025-04-08 15:41 ` [Patch v4 net-next 3/3] net: bridge: mcast: Notify on mdb offload failure Joseph Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410201341.17660e10@kernel.org \
--to=kuba@kernel.org \
--cc=Joseph.Huang@garmin.com \
--cc=andrew+netdev@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joseph.huang.2024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).