From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A85B742065 for ; Fri, 29 Aug 2025 09:55:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756461320; cv=none; b=rC3oBPeWmX808vLlR5plSZK80xe7aI6FVeHMwxTDou2Cj+3M+R595lgvdRdSKooxptinJXErb0VDiW8dDHJuJPJ5Js16KCvclAegufxi1zHuN1j1nSMO0vcPMdc9TRocTlN+l9UYfRURgITzPEa3Sxhkymg9Ri8gdc26Yg2piYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756461320; c=relaxed/simple; bh=LiVImEpioxdBOP+MyMS2h1ZlaeZCUIfiDXqjrFdT9As=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ulixENivnSHp9ZhPVuNvwgVebQK3IFXIqLe5Pu01R/PrCFxOm9EcW2onOXObVtBP435MtQ/QbRq2hTXlr8ssrn3BAwv+WKrnRkcY9TTnX9hqyFdcuk0v4T9/OWdJl25TyPdwChpGRUyaHJGN7GJuq3mJG6qQ+hEkN0WOYuJPvww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kTspMlwZ; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kTspMlwZ" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-771e987b4e6so1512091b3a.2 for ; Fri, 29 Aug 2025 02:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756461318; x=1757066118; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8STPzJQjMixAmB2XXIlQI79JTr2hM8zL3iYx8fSGol4=; b=kTspMlwZ8odKEDNlzEF8PHxu9Ofnv0KI9mmpMqmDiBMTdQbnWtevDvl9jZAflnqEbq C2oAPcRgfje4YcYwvKQHU27Ap9gNfVDGRIHwnOCLMGJjk3iuxTmc4uX/n88qSI1rARGo qOPPuTwmPgODsaegqMmoT4r8iWncosggPa1HqzLj2jAN6e9yxULaM1LA8IBlXaWM59r1 /L/ZU7/i5hkPZGHzejiTAOIN+VECB7KWKyBH2PZSg9/YCiQlZwel8ItFPhK8eNKwoLwl ZXQ8v1+GIbsT+AdzKKdVYkT0I6Fj1+HvdQrqlPiN/Yt+rfO3NWb+kkaXXMYJu0GTodjo GJtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756461318; x=1757066118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8STPzJQjMixAmB2XXIlQI79JTr2hM8zL3iYx8fSGol4=; b=vgfl6sbNJ9D2lb0ERyvfSmgaeHAN7SsHqZPIKZCFv8i2kIdnYFJVWyaD78vwsRIiTL hl2WH0eV1axbBndA7Z9Ml/1Gb9XzQfFBUKLpYYnoW10QeppWicwc/LbSrjXIfLLPj8EK qJR8ZOPUgSqSxMoMG3xmX50zhD8eyBLkGJxAIJCrT8YgHxxYAdDuaLlPw4G0nSRLGY5b V1aC4D8hQh0OwbHM35ZeS9gdkvgesGTD0EtVeZfb/IMeYwdpywb2EXDOwvBUuBfjvrb6 YMS6b1u3268q4fRIfbCzN2HfG8ek5irGzXyEYnKUsgdP0DO4vDaqVX/q/+JnEr0xOpSw 9YxQ== X-Forwarded-Encrypted: i=1; AJvYcCUrMmuYhGLtUNVH690dVGCnFQ1m7jsjdLE3sOIa5THIskKNecxUoyU3WRDmd67sVC8coDKjVOI=@lists.linux.dev X-Gm-Message-State: AOJu0YykaaZn85XVnAokw3SedZEA6c9LNGhFV0JgH0CWnoDBvFbQkZIA SHkKjke5G8/JE1dQlmZaF8xKOp96682uKaiqv/fWXqknWx6Onfm6651m X-Gm-Gg: ASbGncvqRlaLEbzaHz9HhBX3ZPOEmZ6d+DhtPzRGtLHNuFRaUouImSFsmwchwywjJod eGJcclbvkIZ5AC+q9SqQEgIKG4PvAU2xnlVy1WxQ+4dJmJx0VsfbvN6jA5wKrzzHDuy6EMBF+02 xqhXjT8MsM6cIb4AsNtmxl6bQY5t9SBmmyEnmjAhFCbO0tNgK7H7Cc4I38TL6bZWkFGSMW+3LBm +5XN+sxw+fzoNuA3me/iJZyh+fmAotpd64chNnPwRQGubi9e4cDIQKU8Htqh7AY3gWJOnHQBnVd 5jibt9hJVnt4S3Yv2bots9kqHtoy3S97svIOjoX51p5AR7Zs41S3RI9tWgcYkh94Tjsm9DudID3 seiO4ZODfx+HiueTPu6spq6if31ZT8magrddU741RFFSA50KAWlJU X-Google-Smtp-Source: AGHT+IFNGbZv0dQtzZb4zPMaDyhTkHdTuimS5iq4evW7KFiZQS+mSzCJskXqDa9/OvWftLmGF5R9Wg== X-Received: by 2002:a05:6a20:4320:b0:240:11b3:bf25 with SMTP id adf61e73a8af0-24340b7ab93mr39909075637.3.1756461317925; Fri, 29 Aug 2025 02:55:17 -0700 (PDT) Received: from fedora.redhat.com ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b4cd347db1fsm1751528a12.47.2025.08.29.02.55.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 02:55:17 -0700 (PDT) From: Hangbin Liu To: netdev@vger.kernel.org Cc: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sabrina Dubroca , Jiri Pirko , Simon Horman , Nikolay Aleksandrov , Ido Schimmel , Shuah Khan , Stanislav Fomichev , Kuniyuki Iwashima , Ahmed Zaki , Alexander Lobakin , bridge@lists.linux.dev, linux-kselftest@vger.kernel.org, Hangbin Liu Subject: [PATCH net-next 5/5] selftests/net: add offload checking test for virtual interface Date: Fri, 29 Aug 2025 09:54:30 +0000 Message-ID: <20250829095430.443891-6-liuhangbin@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250829095430.443891-1-liuhangbin@gmail.com> References: <20250829095430.443891-1-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: bridge@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit make sure the virtual interface offload setting is correct after changing lower devices. Signed-off-by: Hangbin Liu --- tools/testing/selftests/net/config | 2 + tools/testing/selftests/net/vdev_offload.sh | 174 ++++++++++++++++++++ 2 files changed, 176 insertions(+) create mode 100755 tools/testing/selftests/net/vdev_offload.sh diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config index d548611e2698..0f3a64a86474 100644 --- a/tools/testing/selftests/net/config +++ b/tools/testing/selftests/net/config @@ -117,6 +117,7 @@ CONFIG_IP_SCTP=m CONFIG_NETFILTER_XT_MATCH_POLICY=m CONFIG_CRYPTO_ARIA=y CONFIG_XFRM_INTERFACE=m +CONFIG_XFRM_OFFLOAD=y CONFIG_XFRM_USER=m CONFIG_IP_NF_MATCH_RPFILTER=m CONFIG_IP6_NF_MATCH_RPFILTER=m @@ -128,3 +129,4 @@ CONFIG_NETKIT=y CONFIG_NET_PKTGEN=m CONFIG_IPV6_ILA=m CONFIG_IPV6_RPL_LWTUNNEL=y +CONFIG_NET_TEAM=m diff --git a/tools/testing/selftests/net/vdev_offload.sh b/tools/testing/selftests/net/vdev_offload.sh new file mode 100755 index 000000000000..4926774aef19 --- /dev/null +++ b/tools/testing/selftests/net/vdev_offload.sh @@ -0,0 +1,174 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +# shellcheck disable=SC1091 +source lib.sh + +# Set related offload on lower deivces and check if upper devices re-compute +# Some fatures are fixed on veth interface. Just list here in case we have a +# better way to test in future. +set_offload() +{ + local dev="$1" + local state="$2" + + # VLAN features + # NETIF_F_FRAGLIST: tx-scatter-gather-fraglist + # shellcheck disable=SC2154 + ip netns exec "$ns" ethtool -K "$dev" tx-scatter-gather-fraglist "$state" + + # ENC features + # NETIF_F_RXCSUM: rx-checksum (bond/team/bridge fixed) + + # XFRM features (veth fixed, netdevsim supports) + # NETIF_F_HW_ESP: esp-hw-offload + # NETIF_F_GSO_ESP: tx-esp-segmentation + + # GSO partial features + # NETIF_F_GSO_PARTIAL: tx-gso-partial (veth/bond fixed) + + # Common features + # NETIF_F_SG: tx-scatter-gather + ip netns exec "$ns" ethtool -K "$dev" tx-scatter-gather "$state" &> /dev/null + # NETIF_F_GSO_SOFTWARE: NETIF_F_GSO_ACCECN: tx-tcp-accecn-segmentation + ip netns exec "$ns" ethtool -K "$dev" tx-tcp-accecn-segmentation "$state" + # NETIF_F_GSO_SOFTWARE: NETIF_F_GSO_SCTP: tx-sctp-segmentation + ip netns exec "$ns" ethtool -K "$dev" tx-sctp-segmentation "$state" + # NETIF_F_GSO_SOFTWARE: NETIF_F_GSO_FRAGLIST: tx-gso-list + ip netns exec "$ns" ethtool -K "$dev" tx-gso-list "$state" +} + +__check_offload() +{ + local dev=$1 + local opt=$2 + local expect=$3 + + ip netns exec "$ns" ethtool --json -k "$dev" | \ + jq -r -e ".[].\"$opt\".active == ${expect}" >/dev/null +} + +check_offload() +{ + local dev=$1 + local state=$2 + RET=0 + + __check_offload "$dev" "tx-scatter-gather-fraglist" "$state" || RET=1 + __check_offload "$dev" "tx-scatter-gather" "$state" || RET=1 + __check_offload "$dev" "tx-tcp-accecn-segmentation" "$state" || RET=1 + __check_offload "$dev" "tx-sctp-segmentation" "$state" || RET=1 + __check_offload "$dev" "tx-gso-list" "$state" || RET=1 +} + +setup_veth() +{ + # Set up test netns + setup_ns ns switch + + # shellcheck disable=SC2154 + ip -n "$ns" link add veth0 type veth peer name veth0 netns "$switch" + ip -n "$ns" link add veth1 type veth peer name veth1 netns "$switch" + ip -n "$switch" link set veth0 up + ip -n "$switch" link set veth1 up + + link_0=veth0 + link_1=veth1 +} + +setup_netdevsim() +{ + setup_ns ns + # The create_netdevsim() function will set the interface up. Later, + # when it is added to bonded, we need to set it down first. And when + # set down, it will have no carrier. So we need to add netdevsim ourselves. + modprobe netdevsim + udevadm settle + echo "0 2" | ip netns exec "$ns" tee /sys/bus/netdevsim/new_device >/dev/null + link_0=$(ip netns exec "$ns" ls /sys/bus/netdevsim/devices/netdevsim0/net | head -n 1) + link_1=$(ip netns exec "$ns" ls /sys/bus/netdevsim/devices/netdevsim0/net | tail -n 1) +} + +cleanup() +{ + cleanup_netdevsim 0 + cleanup_all_ns +} + +setup_bond() +{ + ip -n "$ns" link set "$link_0" nomaster + ip -n "$ns" link set "$link_1" nomaster + ip -n "$ns" link add bond0 type bond mode active-backup miimon 100 + ip -n "$ns" link set "$link_0" master bond0 + ip -n "$ns" link set "$link_1" master bond0 + ip -n "$ns" link set bond0 up +} + +setup_team() +{ + ip -n "$ns" link set "$link_0" nomaster + ip -n "$ns" link set "$link_1" nomaster + ip -n "$ns" link add team0 type team + ip -n "$ns" link set "$link_0" master team0 + ip -n "$ns" link set "$link_1" master team0 + ip -n "$ns" link set team0 up +} + +setup_bridge() +{ + ip -n "$ns" link set "$link_0" nomaster + ip -n "$ns" link set "$link_1" nomaster + ip -n "$ns" link add br0 type bridge + ip -n "$ns" link set "$link_0" master br0 + ip -n "$ns" link set "$link_1" master br0 + ip -n "$ns" link set br0 up +} + +check_xfrm() +{ + local dev=$1 + local src=192.0.2.1 + local dst=192.0.2.2 + local key="0x3132333435363738393031323334353664636261" + + RET=0 + + ip -n "$ns" xfrm state flush + ip -n "$ns" xfrm state add proto esp src "$src" dst "$dst" spi 9 \ + mode transport reqid 42 aead "rfc4106(gcm(aes))" "$key" 128 \ + sel src "$src"/24 dst "$dst"/24 offload dev "$dev" dir out + + # shellcheck disable=SC2034 + ip -n "$ns" xfrm state list | grep -q "crypto offload parameters: dev $dev dir" || RET=1 + log_test "$dev" "xfrm offload" +} + +do_test() +{ + local dev=$1 + set_offload veth0 "on" + set_offload veth1 "on" + check_offload "$dev" "true" + log_test "$dev" "enable offload" + + set_offload veth0 "off" + set_offload veth1 "off" + check_offload "$dev" "false" + log_test "$dev" "disable offload" +} + +trap cleanup EXIT +setup_veth +setup_bond +do_test bond0 +setup_team +do_test team0 +setup_bridge +do_test br0 + +# Check NETIF_F_HW_ESP +# Only test bond as team and bridge haven't implemented xfrm offload +setup_netdevsim +setup_bond +check_xfrm bond0 -- 2.50.1