From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sabrina Dubroca <sdubroca@redhat.com>,
Jiri Pirko <jiri@resnulli.us>, Simon Horman <horms@kernel.org>,
Ido Schimmel <idosch@nvidia.com>, Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Kuniyuki Iwashima <kuniyu@google.com>,
Ahmed Zaki <ahmed.zaki@intel.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
bridge@lists.linux.dev, linux-kselftest@vger.kernel.org,
Hangbin Liu <liuhangbin@gmail.com>
Subject: [PATCHv2 net-next 5/5] selftests/net: add offload checking test for virtual interface
Date: Tue, 2 Sep 2025 07:26:02 +0000 [thread overview]
Message-ID: <20250902072602.361122-6-liuhangbin@gmail.com> (raw)
In-Reply-To: <20250902072602.361122-1-liuhangbin@gmail.com>
make sure the virtual interface offload setting is correct after
changing lower devices.
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/net/Makefile | 1 +
tools/testing/selftests/net/config | 2 +
tools/testing/selftests/net/vdev_offload.sh | 176 ++++++++++++++++++++
3 files changed, 179 insertions(+)
create mode 100755 tools/testing/selftests/net/vdev_offload.sh
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index eef0b8f8a7b0..e195ab4038a0 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -118,6 +118,7 @@ TEST_PROGS += tfo_passive.sh
TEST_PROGS += broadcast_pmtu.sh
TEST_PROGS += ipv6_force_forwarding.sh
TEST_PROGS += route_hint.sh
+TEST_PROGS += vdev_offload.sh
# YNL files, must be before "include ..lib.mk"
YNL_GEN_FILES := busy_poller netlink-dumps
diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
index d548611e2698..0f3a64a86474 100644
--- a/tools/testing/selftests/net/config
+++ b/tools/testing/selftests/net/config
@@ -117,6 +117,7 @@ CONFIG_IP_SCTP=m
CONFIG_NETFILTER_XT_MATCH_POLICY=m
CONFIG_CRYPTO_ARIA=y
CONFIG_XFRM_INTERFACE=m
+CONFIG_XFRM_OFFLOAD=y
CONFIG_XFRM_USER=m
CONFIG_IP_NF_MATCH_RPFILTER=m
CONFIG_IP6_NF_MATCH_RPFILTER=m
@@ -128,3 +129,4 @@ CONFIG_NETKIT=y
CONFIG_NET_PKTGEN=m
CONFIG_IPV6_ILA=m
CONFIG_IPV6_RPL_LWTUNNEL=y
+CONFIG_NET_TEAM=m
diff --git a/tools/testing/selftests/net/vdev_offload.sh b/tools/testing/selftests/net/vdev_offload.sh
new file mode 100755
index 000000000000..78fc212efd4a
--- /dev/null
+++ b/tools/testing/selftests/net/vdev_offload.sh
@@ -0,0 +1,176 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+
+# shellcheck disable=SC1091
+source lib.sh
+
+# Set related offload on lower deivces and check if upper devices re-compute
+# Some features are fixed on veth interface. Just list here in case we have a
+# better way to test in future.
+set_offload()
+{
+ local dev="$1"
+ local state="$2"
+
+ # VLAN features
+ # NETIF_F_FRAGLIST: tx-scatter-gather-fraglist
+ # shellcheck disable=SC2154
+ ip netns exec "$ns" ethtool -K "$dev" tx-scatter-gather-fraglist "$state"
+
+ # ENC features
+ # NETIF_F_RXCSUM: rx-checksum (bond/team/bridge fixed)
+
+ # XFRM features (veth fixed, netdevsim supports)
+ # NETIF_F_HW_ESP: esp-hw-offload
+ # NETIF_F_GSO_ESP: tx-esp-segmentation
+
+ # GSO partial features
+ # NETIF_F_GSO_PARTIAL: tx-gso-partial (veth/bond fixed)
+
+ # Common features
+ # NETIF_F_SG: tx-scatter-gather
+ ip netns exec "$ns" ethtool -K "$dev" tx-scatter-gather "$state" &> /dev/null
+ # NETIF_F_GSO_SOFTWARE: NETIF_F_GSO_ACCECN: tx-tcp-accecn-segmentation
+ ip netns exec "$ns" ethtool -K "$dev" tx-tcp-accecn-segmentation "$state"
+ # NETIF_F_GSO_SOFTWARE: NETIF_F_GSO_SCTP: tx-sctp-segmentation
+ ip netns exec "$ns" ethtool -K "$dev" tx-sctp-segmentation "$state"
+ # NETIF_F_GSO_SOFTWARE: NETIF_F_GSO_FRAGLIST: tx-gso-list
+ ip netns exec "$ns" ethtool -K "$dev" tx-gso-list "$state"
+}
+
+__check_offload()
+{
+ local dev=$1
+ local opt=$2
+ local expect=$3
+
+ ip netns exec "$ns" ethtool --json -k "$dev" | \
+ jq -r -e ".[].\"$opt\".active == ${expect}" >/dev/null
+}
+
+check_offload()
+{
+ local dev=$1
+ local state=$2
+
+ __check_offload "$dev" "tx-scatter-gather-fraglist" "$state" || RET=1
+ __check_offload "$dev" "tx-scatter-gather" "$state" || RET=1
+ __check_offload "$dev" "tx-tcp-accecn-segmentation" "$state" || RET=1
+ __check_offload "$dev" "tx-sctp-segmentation" "$state" || RET=1
+ __check_offload "$dev" "tx-gso-list" "$state" || RET=1
+}
+
+setup_veth()
+{
+ # Set up test netns
+ setup_ns ns switch
+
+ # shellcheck disable=SC2154
+ ip -n "$ns" link add veth0 type veth peer name veth0 netns "$switch"
+ ip -n "$ns" link add veth1 type veth peer name veth1 netns "$switch"
+ ip -n "$switch" link set veth0 up
+ ip -n "$switch" link set veth1 up
+
+ link_0=veth0
+ link_1=veth1
+}
+
+setup_netdevsim()
+{
+ setup_ns ns
+ # The create_netdevsim() function will set the interface up. Later,
+ # when it is added to bonded, we need to set it down first. And when
+ # set down, it will have no carrier. So we need to add netdevsim ourselves.
+ modprobe netdevsim
+ udevadm settle
+ echo "0 2" | ip netns exec "$ns" tee /sys/bus/netdevsim/new_device >/dev/null
+ link_0=$(ip netns exec "$ns" ls /sys/bus/netdevsim/devices/netdevsim0/net | head -n 1)
+ link_1=$(ip netns exec "$ns" ls /sys/bus/netdevsim/devices/netdevsim0/net | tail -n 1)
+}
+
+cleanup()
+{
+ cleanup_netdevsim 0
+ cleanup_all_ns
+}
+
+setup_bond()
+{
+ ip -n "$ns" link set "$link_0" nomaster
+ ip -n "$ns" link set "$link_1" nomaster
+ ip -n "$ns" link add bond0 type bond mode active-backup miimon 100
+ ip -n "$ns" link set "$link_0" master bond0
+ ip -n "$ns" link set "$link_1" master bond0
+ ip -n "$ns" link set bond0 up
+}
+
+setup_team()
+{
+ ip -n "$ns" link set "$link_0" nomaster
+ ip -n "$ns" link set "$link_1" nomaster
+ ip -n "$ns" link add team0 type team
+ ip -n "$ns" link set "$link_0" master team0
+ ip -n "$ns" link set "$link_1" master team0
+ ip -n "$ns" link set team0 up
+}
+
+setup_bridge()
+{
+ ip -n "$ns" link set "$link_0" nomaster
+ ip -n "$ns" link set "$link_1" nomaster
+ ip -n "$ns" link add br0 type bridge
+ ip -n "$ns" link set "$link_0" master br0
+ ip -n "$ns" link set "$link_1" master br0
+ ip -n "$ns" link set br0 up
+}
+
+check_xfrm()
+{
+ local dev=$1
+ local src=192.0.2.1
+ local dst=192.0.2.2
+ local key="0x3132333435363738393031323334353664636261"
+
+ RET=0
+
+ ip -n "$ns" xfrm state flush
+ ip -n "$ns" xfrm state add proto esp src "$src" dst "$dst" spi 9 \
+ mode transport reqid 42 aead "rfc4106(gcm(aes))" "$key" 128 \
+ sel src "$src"/24 dst "$dst"/24 offload dev "$dev" dir out
+
+ # shellcheck disable=SC2034
+ ip -n "$ns" xfrm state list | grep -q "crypto offload parameters: dev $dev dir" || RET=1
+ log_test "$dev" "xfrm offload"
+}
+
+do_test()
+{
+ local dev=$1
+
+ RET=0
+ set_offload veth0 "on"
+ set_offload veth1 "on"
+ check_offload "$dev" "true"
+ log_test "$dev" "enable offload"
+
+ RET=0
+ set_offload veth0 "off"
+ set_offload veth1 "off"
+ check_offload "$dev" "false"
+ log_test "$dev" "disable offload"
+}
+
+trap cleanup EXIT
+setup_veth
+setup_bond
+do_test bond0
+setup_team
+do_test team0
+setup_bridge
+do_test br0
+
+# Check NETIF_F_HW_ESP
+# Only test bond as team and bridge haven't implemented xfrm offload
+setup_netdevsim
+setup_bond
+check_xfrm bond0
--
2.50.1
next prev parent reply other threads:[~2025-09-02 7:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 7:25 [PATCHv2 net-next 0/5] net: common feature compute for upper interface Hangbin Liu
2025-09-02 7:25 ` [PATCHv2 net-next 1/5] net: add a common function to compute features from lowers devices Hangbin Liu
2025-09-06 17:42 ` Sabrina Dubroca
2025-09-08 3:20 ` Hangbin Liu
2025-09-07 0:22 ` Jakub Kicinski
2025-09-02 7:25 ` [PATCHv2 net-next 2/5] bonding: use common function to compute the features Hangbin Liu
2025-09-02 7:26 ` [PATCHv2 net-next 3/5] team: " Hangbin Liu
2025-09-02 7:26 ` [PATCHv2 net-next 4/5] net: bridge: " Hangbin Liu
2025-09-02 7:26 ` Hangbin Liu [this message]
2025-09-06 21:30 ` [PATCHv2 net-next 5/5] selftests/net: add offload checking test for virtual interface Sabrina Dubroca
2025-09-08 4:15 ` Hangbin Liu
2025-09-08 9:36 ` Sabrina Dubroca
2025-09-08 10:14 ` Hangbin Liu
2025-09-08 21:48 ` Sabrina Dubroca
2025-09-09 2:54 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902072602.361122-6-liuhangbin@gmail.com \
--to=liuhangbin@gmail.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=sdubroca@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).