bridge.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: Jay Vosburgh <jv@jvosburgh.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Sabrina Dubroca <sdubroca@redhat.com>,
	Jiri Pirko <jiri@resnulli.us>, Simon Horman <horms@kernel.org>,
	Ido Schimmel <idosch@nvidia.com>, Shuah Khan <shuah@kernel.org>,
	Stanislav Fomichev <sdf@fomichev.me>,
	Stanislav Fomichev <stfomichev@gmail.com>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	Alexander Lobakin <aleksander.lobakin@intel.com>,
	bridge@lists.linux.dev, Hangbin Liu <liuhangbin@gmail.com>
Subject: [PATCHv6 net-next 0/4] net: common feature compute for upper interface
Date: Fri, 17 Oct 2025 03:41:51 +0000	[thread overview]
Message-ID: <20251017034155.61990-1-liuhangbin@gmail.com> (raw)

Some high-level virtual drivers need to compute features from their
lower devices, but each currently has its own implementation and may
miss some feature computations. This patch set introduces a common function
to compute features for such devices.

Currently, bonding, team, and bridge have been updated to use the new
helper.

v6:
  * no update, only rename UPPER_DEV_* to MASTER_UPPER_DEV_* (Jiri Pirko)

v5:
  * rename VIRTUAL_DEV_* to UPPER_DEV_* (Jiri Pirko)
  * use IS_ENABLED() instead of ifdef (Simon Horman)
  * init max_headroom/tailroom (Simon Horman)
  * link: https://lore.kernel.org/netdev/20251016033828.59324-1-liuhangbin@gmail.com

v4:
  * update needed_{headroom, tailroom} in the common helper (Ido Schimmel)
  * remove unneeded err in team (Stanislav Fomichev)
  * remove selftest as `ethtool -k` does not test the dev->*_features. We
    can add back the selftest when there is a good way to test. (Sabrina Dubroca)
  * link: https://lore.kernel.org/netdev/20251014080217.47988-1-liuhangbin@gmail.com

v3:
  a) fix hw_enc_features assign order (Sabrina Dubroca)
  b) set virtual dev feature definition in netdev_features.h (Jakub Kicinski)
  c) remove unneeded err in team_del_slave (Stanislav Fomichev)
  d) remove NETIF_F_HW_ESP test as it needs to be test with GSO pkts (Sabrina Dubroca)

v2:
  a) remove hard_header_len setting. I will set needed_headroom for bond/team
     in a separate patch as bridge has it's own ways. (Ido Schimmel)
  b) Add test file to Makefile, set RET=0 to a proper location. (Ido Schimmel)

Hangbin Liu (4):
  net: add a common function to compute features for upper devices
  bonding: use common function to compute the features
  team: use common function to compute the features
  net: bridge: use common function to compute the features

 drivers/net/bonding/bond_main.c | 99 ++-------------------------------
 drivers/net/team/team_core.c    | 83 ++-------------------------
 include/linux/netdev_features.h | 18 ++++++
 include/linux/netdevice.h       |  1 +
 net/bridge/br_if.c              | 22 +-------
 net/core/dev.c                  | 88 +++++++++++++++++++++++++++++
 6 files changed, 120 insertions(+), 191 deletions(-)

-- 
2.50.1


             reply	other threads:[~2025-10-17  3:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17  3:41 Hangbin Liu [this message]
2025-10-17  3:41 ` [PATCHv6 net-next 1/4] net: add a common function to compute features for upper devices Hangbin Liu
2025-10-20  9:10   ` Sabrina Dubroca
2025-10-21  4:03     ` Hangbin Liu
2025-10-21  8:46     ` Paolo Abeni
2025-10-21 10:05       ` Hangbin Liu
2025-10-21 16:52       ` Sabrina Dubroca
2025-10-17  3:41 ` [PATCHv6 net-next 2/4] bonding: use common function to compute the features Hangbin Liu
2025-10-20  9:10   ` Sabrina Dubroca
2025-10-17  3:41 ` [PATCHv6 net-next 3/4] team: " Hangbin Liu
2025-10-20  9:11   ` Sabrina Dubroca
2025-10-17  3:41 ` [PATCHv6 net-next 4/4] net: bridge: " Hangbin Liu
2025-10-20  9:17   ` Sabrina Dubroca
2025-10-17  9:58 ` [PATCHv6 net-next 0/4] net: common feature compute for upper interface Jiri Pirko
2025-10-22  1:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251017034155.61990-1-liuhangbin@gmail.com \
    --to=liuhangbin@gmail.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bridge@lists.linux.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=jiri@resnulli.us \
    --cc=jv@jvosburgh.net \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=sdubroca@redhat.com \
    --cc=shuah@kernel.org \
    --cc=stfomichev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).