From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E57342E7166 for ; Mon, 15 Dec 2025 20:42:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765831324; cv=none; b=B+ShtSLXfFGndKK2FWN8BcQ6zXmkDrTZThKzOX/pr8VWBW8O/FtifbQL75KBiz2ku04qk06iYm79ptBQOjmt8VdVyCoDE6HDAM+ukVpwGTzvI34tt0pH8SwfykER0q9Yod6wqIqA7iJ0v/kum7z3WQhui01j9AwCDlKjkBuOe8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765831324; c=relaxed/simple; bh=Tg2Hz5s/jJowltHvM8wwgjOW8nNKrG1QcZozg60XeFs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=Bhvfti4MdZIOvA845bzUQpEdqatvzYezF1+Bczm+THPsrKwg+XjpfiOroUSVwSxqm+qjJ70RZESjMe1AFNU79Caea2U535QVOXMSFBqEW5mI1Xy8mTb6o772vrrRn1l/CTADUUlnTW5Uoj8utbQ46Y/aWA+0mEu70xjLjxNqcHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QYINGqbb; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QYINGqbb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765831320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vIugujDFg05cEDjSFPsNuy7/nXwlnSCGQEq9oeQZt8U=; b=QYINGqbbRc/FUPodLAsCOdI6iNJAWOz0cigxmje7v9iWY2vLYqh+36mxn5Y5flqd6pqz7Q KThVt3n4fWMSeeREoC+OK4qOLZvpPJorz6TWmltzE9jEw1AlT0V4F5jCrS9JShHdvJgRj5 Y5Ftn3TVUE0L6Aa/NL+XTp0JrK0Vumc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-XqiDHUxGNo6-L1UqSIoXqg-1; Mon, 15 Dec 2025 15:41:59 -0500 X-MC-Unique: XqiDHUxGNo6-L1UqSIoXqg-1 X-Mimecast-MFC-AGG-ID: XqiDHUxGNo6-L1UqSIoXqg_1765831318 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-477cf2230c8so37539355e9.0 for ; Mon, 15 Dec 2025 12:41:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765831318; x=1766436118; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vIugujDFg05cEDjSFPsNuy7/nXwlnSCGQEq9oeQZt8U=; b=JUl9T19bOSqPQ+z5G0UpRmKISPJ+WbntzNro3FT8LsS3FS6rQa8kEM1s6Yk7zQYoFg nXUJgaBoR+IyDuJvp9bgKxa2O9TIOUw0Ehilqx1R4T6eQ2EFOrT1NqBKgN2aa8qXCv/k MM9gI2kC0AwzbWYzUd7e2gffknHQojOFE4Wv0j/vEuYg9mlt9sBZ0aat5uYdjIApx8qs L4NWeYqyEOawKQx2YcnTt0lcJOEMlyR1Yarp6p3AlPbh5ILrX3qV058W+PrHEdhUgHB/ qbNtczSYKRoK8218/BUFC2yZiDxiTk5USQBkgR4dprGRba+QgqqABuSDi3r2vE5xhkr/ oivw== X-Forwarded-Encrypted: i=1; AJvYcCWODW6wTL9HNRvX1vkf4x9RIhbVu7KDJhJV8RMD0IBJcYAm4mrXgS9rY7VuDcn+TEZWsFofrJw=@lists.linux.dev X-Gm-Message-State: AOJu0YzmQvSg0u3n/YiHCbJm7/TOql2dZUQuVsp4Xc2tFjCc6fAg9fFL 6FdidapHlXgRbF9m9PBA76wXRlbqGhcRwcPaObWE83udjCWi+yFRVVD2qYvOOCcg22ICO09N96L IP1HT+ce66T0K46I9dzrKhWwRL3yaodMKeiP3z28108qUAXzJdOfgQDQnNw== X-Gm-Gg: AY/fxX6uULgoZwEuGp2cYLb3SAyrnmvb5Uq62aJRpwRYhdTjbSN2l2iGvwiMt55U9pG 6K81Fx8Vfkp6tdN8tYOcTDtehVPMabQ4wmEsleFXywpd8yVWRJxsUooG5DRzmg+POrtxIkRARvV 1QDdP7rPODmYS8BIFVzmxCoIQSJMulNkgfUULGECrBufxKoNGaCAJk0J5dvPltWImrwq6iPXUe/ 3U/Hcg8SwmxDB0q2pFqpA3/iMAZI5FY4cOD2vSlJwve4yEAvF5mYLPO9BtrrxBQB5Txd1Lw1MIL kpVCCzxrrkJdondZqddTGCG4/70DoX/POTzuqaHCp9eR/SUTCVpLtk2G9TBWpg5TY8eNRiLTbvt Y9Z7wfD4qnb2ASRi2XMSQ+LYSePkYgkffEA== X-Received: by 2002:a05:600c:6290:b0:477:76bf:e1fb with SMTP id 5b1f17b1804b1-47a8f8cdfd1mr164694715e9.16.1765831318224; Mon, 15 Dec 2025 12:41:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFpvKxyv9KrTZN+I+gLKkWZxXPblkRG4VaB9KOKEG2SIjVVbTsH1HJ4pcy9Q9bDzIs00zZydQ== X-Received: by 2002:a05:600c:6290:b0:477:76bf:e1fb with SMTP id 5b1f17b1804b1-47a8f8cdfd1mr164694005e9.16.1765831317597; Mon, 15 Dec 2025 12:41:57 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f6f26ebsm211656485e9.14.2025.12.15.12.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 12:41:56 -0800 (PST) Date: Mon, 15 Dec 2025 15:41:49 -0500 From: "Michael S. Tsirkin" To: Bagas Sanjaya Cc: Linux Kernel Mailing List , Linux AMDGPU , Linux DRI Development , Linux Filesystems Development , Linux Media , linaro-mm-sig@lists.linaro.org, kasan-dev@googlegroups.com, Linux Virtualization , Linux Memory Management List , Linux Network Bridge , Linux Networking , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthew Brost , Danilo Krummrich , Philipp Stanner , Alexander Viro , Christian Brauner , Jan Kara , Sumit Semwal , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton , Uladzislau Rezki , Nikolay Aleksandrov , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Taimur Hassan , Wayne Lin , Alex Hung , Aurabindo Pillai , Dillon Varone , George Shen , Aric Cyr , Cruise Hung , Mario Limonciello , Sunil Khatri , Dominik Kaszewski , David Hildenbrand , Peter Zijlstra , Lorenzo Stoakes , Max Kellermann , "Nysal Jan K.A." , Ryan Roberts , Alexey Skidanov , Vlastimil Babka , Kent Overstreet , Vitaly Wool , Harry Yoo , Mateusz Guzik , NeilBrown , Amir Goldstein , Jeff Layton , Ivan Lipski , Tao Zhou , YiPeng Chai , Hawking Zhang , Lyude Paul , Daniel Almeida , Luben Tuikov , Matthew Auld , Roopa Prabhu , Mao Zhu , Shaomin Deng , Charles Han , Jilin Yuan , Swaraj Gaikwad , George Anthony Vernon Subject: Re: [PATCH 06/14] virtio: Describe @map and @vmap members in virtio_device struct Message-ID: <20251215154141-mutt-send-email-mst@kernel.org> References: <20251215113903.46555-1-bagasdotme@gmail.com> <20251215113903.46555-7-bagasdotme@gmail.com> Precedence: bulk X-Mailing-List: bridge@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20251215113903.46555-7-bagasdotme@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kHwlRFbJ1jQsJIz7bKeHFh2REe36iNMHDy83uhhB_wI_1765831318 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 15, 2025 at 06:38:54PM +0700, Bagas Sanjaya wrote: > Sphinx reports kernel-doc warnings: > > WARNING: ./include/linux/virtio.h:181 struct member 'map' not described in 'virtio_device' > WARNING: ./include/linux/virtio.h:181 struct member 'vmap' not described in 'virtio_device' > > Describe these members. > > Fixes: bee8c7c24b7373 ("virtio: introduce map ops in virtio core") > Signed-off-by: Bagas Sanjaya Acked-by: Michael S. Tsirkin > --- > include/linux/virtio.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/virtio.h b/include/linux/virtio.h > index 132a474e59140a..68ead8fda9c921 100644 > --- a/include/linux/virtio.h > +++ b/include/linux/virtio.h > @@ -150,11 +150,13 @@ struct virtio_admin_cmd { > * @id: the device type identification (used to match it with a driver). > * @config: the configuration ops for this device. > * @vringh_config: configuration ops for host vrings. > + * @map: configuration ops for device's mapping buffer > * @vqs: the list of virtqueues for this device. > * @features: the 64 lower features supported by both driver and device. > * @features_array: the full features space supported by both driver and > * device. > * @priv: private pointer for the driver's use. > + * @vmap: device virtual map > * @debugfs_dir: debugfs directory entry. > * @debugfs_filter_features: features to be filtered set by debugfs. > */ > -- > An old man doll... just what I always wanted! - Clara