From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D788379C35; Wed, 30 Sep 2026 15:57:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783855; cv=none; b=ew62pvZP4tfArNmn0I9beah7NxICvf+/fHP23Fu6Z9zMOhXUNPd/3uAHstEtILG+JyVssfiGOBdt4usoUskOpzH0cpb94Q67Avy3qxlZXwqoHZ81oT3ikz/xYKtAnLj7F8FcH2y+TskrCkRVTe/CDW+dYq/vowqnOK7rY4hFE+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783855; c=relaxed/simple; bh=HapMWFBAR7qo+jfd8f/UTxxtElO/SeWM2BIau6J/DUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y8pRx6pPeSVSWQGdWG52XOD7pdn55WGnGNg1uCwc8qNxdo0HnmveMrh03Vj14XnHf6AQ5poRj+4782Or5XXkf7Tf15VyS0Q5jlBSSuLk4VAy1JC2F8ADOZxYAfDqloFIYiahqbpFUqBv0lQrzwQsFz/L4jPVHd49/Fi001whKBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cshYvoZn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cshYvoZn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 374121F000FF; Wed, 30 Sep 2026 15:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783849; bh=oE6t4NjpSUOFP+Q6odz1hZkb+P2TT2DcMgkFl4GvnvA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cshYvoZna8gkd5IRat0X63IrXyKogOxIUEiHbfhtSG/gF0+0d2G8M+LbGjVvW78dg 9qbOzBsZPwNOxWCMcUrvXuGR+tTrSByUajI+QMhxmbBNudB10P/uKCQzRut30SKlGO avSq60M5/LfEsTNON6t0VSIM/GQUXbxdGBxm2evk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nikolay Aleksandrov , Ido Schimmel , bridge@lists.linux.dev, Eric Dumazet , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 542/595] bridge: check llc_mac_hdr_init() return value in br_send_bpdu() Date: Wed, 30 Sep 2026 17:27:15 +0200 Message-ID: <20260930152359.367811442@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: bridge@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit ac704ff08e511c87643799c385f55ecd69b85e03 ] If llc_mac_hdr_init() fails (for instance if the port device type does not support LLC or dev_hard_header() fails), br_send_bpdu() should drop the skb instead of resetting the mac header to the LLC payload and transmitting a malformed frame. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Closes: https://lore.kernel.org/netdev/179022851638.2160803.1808206741379444999@kernel.org/ Cc: Nikolay Aleksandrov Cc: Ido Schimmel Cc: bridge@lists.linux.dev Signed-off-by: Eric Dumazet Acked-by: Nikolay Aleksandrov Link: https://patch.msgid.link/20260924082951.1599377-3-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/bridge/br_stp_bpdu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_stp_bpdu.c b/net/bridge/br_stp_bpdu.c index 0e4572f313307..1917d11411d72 100644 --- a/net/bridge/br_stp_bpdu.c +++ b/net/bridge/br_stp_bpdu.c @@ -52,7 +52,10 @@ static void br_send_bpdu(struct net_bridge_port *p, LLC_SAP_BSPAN, LLC_PDU_CMD); llc_pdu_init_as_ui_cmd(skb); - llc_mac_hdr_init(skb, p->dev->dev_addr, p->br->group_addr); + if (llc_mac_hdr_init(skb, p->dev->dev_addr, p->br->group_addr)) { + kfree_skb(skb); + return; + } skb_reset_mac_header(skb); -- 2.53.0