From: Haoze Xie <royenheart@gmail.com>
To: Florian Westphal <fw@strlen.de>, Ren Wei <n05ec@lzu.edu.cn>
Cc: netfilter-devel@vger.kernel.org, bridge@lists.linux.dev,
pablo@netfilter.org, phil@nwl.cc, razor@blackwall.org,
idosch@nvidia.com, stephen@networkplumber.org,
sw@simonwunderlich.de, davem@davemloft.net, yuantan098@gmail.com,
yifanwucs@gmail.com, tomapufckgml@gmail.com, bird@lzu.edu.cn
Subject: Re: [PATCH nf v2 1/1] bridge: br_netfilter: move fake rtable off struct net_bridge
Date: Thu, 4 Jun 2026 09:52:38 +0800 [thread overview]
Message-ID: <2bbc19cf-e098-46dd-ad76-a4862229786b@gmail.com> (raw)
In-Reply-To: <aiC7dFYZpiEHZeyG@strlen.de>
On 6/4/2026 7:40 AM, Florian Westphal wrote:
> Florian Westphal <fw@strlen.de> wrote:
>> Ren Wei <n05ec@lzu.edu.cn> wrote:
>>> Use rt_dst_alloc() so the fake dst reuses the core IPv4 rtable
>>> lifecycle, and release the bridge device reference during teardown via
>>> dst_dev_put() before dropping the bridge-owned dst reference.
>>
>> I think AI review is mostly correct:
>> https://sashiko.dev/#/patchset/831936f111e6e1f435f4f6247d07fe6a6624d271.1779680014.git.royenheart%40gmail.com
>>
>> - no need for constant refcount bump
>> - I don't think the ipv4 specific functions can be used safely here.
>
> Are you going to send a new version or should this be treated as
> a bug report?
>
> Thanks.
Sorry about the delay, we're testing and gonna to send a new
version.
prev parent reply other threads:[~2026-06-04 1:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 3:21 [PATCH nf v2 1/1] bridge: br_netfilter: move fake rtable off struct net_bridge Ren Wei
2026-05-27 7:42 ` Florian Westphal
2026-06-03 23:40 ` Florian Westphal
2026-06-04 1:52 ` Haoze Xie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bbc19cf-e098-46dd-ad76-a4862229786b@gmail.com \
--to=royenheart@gmail.com \
--cc=bird@lzu.edu.cn \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=idosch@nvidia.com \
--cc=n05ec@lzu.edu.cn \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=razor@blackwall.org \
--cc=stephen@networkplumber.org \
--cc=sw@simonwunderlich.de \
--cc=tomapufckgml@gmail.com \
--cc=yifanwucs@gmail.com \
--cc=yuantan098@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox