From: "Yang Huajian(杨华健)" <huajianyang@asrmicro.com>
To: "pablo@netfilter.org" <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
"kadlec@netfilter.org" <kadlec@netfilter.org>,
"razor@blackwall.org" <razor@blackwall.org>,
"idosch@nvidia.com" <idosch@nvidia.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"dsahern@kernel.org" <dsahern@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"coreteam@netfilter.org" <coreteam@netfilter.org>,
"bridge@lists.linux.dev" <bridge@lists.linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [PATCH] net: Move specific fragmented packet to slow_path instead of dropping it
Date: Thu, 24 Apr 2025 02:12:02 +0000 [thread overview]
Message-ID: <313bbfd54e6540e58e60dfcd9f0e8b2e@exch03.asrmicro.com> (raw)
In-Reply-To: <aAEMPbbOGZDRygwr@strlen.de>
Hi Pablo,
Can you give some advice?
Thanks.
Best Regards,
Huajian
-----邮件原件-----
发件人: Florian Westphal [mailto:fw@strlen.de]
发送时间: 2025年4月17日 22:12
收件人: Yang Huajian(杨华健) <huajianyang@asrmicro.com>
抄送: pablo@netfilter.org; kadlec@netfilter.org; razor@blackwall.org; idosch@nvidia.com; davem@davemloft.net; dsahern@kernel.org; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; horms@kernel.org; netfilter-devel@vger.kernel.org; coreteam@netfilter.org; bridge@lists.linux.dev; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH] net: Move specific fragmented packet to slow_path instead of dropping it
Huajian Yang <huajianyang@asrmicro.com> wrote:
> The config NF_CONNTRACK_BRIDGE will change the bridge forwarding for
> fragmented packets.
>
> The original bridge does not know that it is a fragmented packet and
> forwards it directly, after NF_CONNTRACK_BRIDGE is enabled, function
> nf_br_ip_fragment and br_ip6_fragment will check the headroom.
>
> In original br_forward, insufficient headroom of skb may indeed exist,
> but there's still a way to save the skb in the device driver after
> dev_queue_xmit.So droping the skb will change the original bridge
> forwarding in some cases.
Fixes: 3c171f496ef5 ("netfilter: bridge: add connection tracking system")
Reviewed-by: Florian Westphal <fw@strlen.de>
This should probably be routed via Pablo.
Pablo, feel free to route this via nf-next if you think its not an urgent fix, its been like this since bridge conntrack was added.
next prev parent reply other threads:[~2025-04-24 2:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 9:29 [PATCH] net: Move specific fragmented packet to slow_path instead of dropping it Huajian Yang
2025-04-17 14:12 ` Florian Westphal
2025-04-24 2:12 ` Yang Huajian(杨华健) [this message]
2025-04-24 21:25 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2025-04-10 7:57 Huajian Yang
2025-04-10 10:18 ` Florian Westphal
2025-04-11 2:43 ` 答复: " Yang Huajian(杨华健)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=313bbfd54e6540e58e60dfcd9f0e8b2e@exch03.asrmicro.com \
--to=huajianyang@asrmicro.com \
--cc=bridge@lists.linux.dev \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).