From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4F15883339 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 85D5783337 MIME-Version: 1.0 Date: Tue, 18 Oct 2022 16:29:05 +0200 From: netdev@kapio-technology.com In-Reply-To: References: <20221009174052.1927483-1-netdev@kapio-technology.com> <20221009174052.1927483-4-netdev@kapio-technology.com> Message-ID: <3246a8d773146f0cbe39dd8ec182efaf@kapio-technology.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v7 net-next 3/9] net: switchdev: add support for offloading of the FDB locked flag List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ido Schimmel Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , linux-kselftest@vger.kernel.org, Joachim Wiberg , Shuah Khan , Ivan Vecera , Florian Fainelli , Daniel Borkmann , Florent Fourcot , bridge@lists.linux-foundation.org, Russell King , linux-arm-kernel@lists.infradead.org, Roopa Prabhu , kuba@kernel.org, Paolo Abeni , Vivien Didelot , Woojung Huh , Landen Chao , Jiri Pirko , Amit Cohen , Christian Marangi , Hauke Mehrtens , Hans Schultz , Sean Wang , DENG Qingfang , Claudiu Manoil , linux-mediatek@lists.infradead.org, Matthias Brugger , Yuwei Wang , Petr Machata , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Vladimir Oltean , davem@davemloft.net On 2022-10-13 16:06, Ido Schimmel wrote: > On Sun, Oct 09, 2022 at 07:40:46PM +0200, Hans J. Schultz wrote: >> Add support for offloading of the MAB/MacAuth feature flag and the FDB >> locked flag which is used by the Mac-Auth/MAB feature. >> >> Signed-off-by: Hans J. Schultz >> --- >> include/net/dsa.h | 2 ++ >> include/net/switchdev.h | 1 + >> net/bridge/br.c | 4 ++-- >> net/bridge/br_fdb.c | 12 ++++++++++-- >> net/bridge/br_private.h | 2 +- >> net/bridge/br_switchdev.c | 3 ++- >> net/dsa/dsa_priv.h | 6 ++++-- >> net/dsa/port.c | 10 ++++++---- >> net/dsa/slave.c | 10 ++++++++-- >> net/dsa/switch.c | 16 ++++++++-------- >> 10 files changed, 44 insertions(+), 22 deletions(-) > > There is more than one logical change here. I suggest splitting it to > make review easier: > > 1. A patch allowing the bridge driver to install locked entries > notified > from device drivers. These changes: > > include/net/switchdev.h | 1 + > net/bridge/br.c | 4 ++-- > net/bridge/br_fdb.c | 12 ++++++++++-- > net/bridge/br_private.h | 2 +- > > And the br_switchdev_fdb_populate() hunk > > 2. A patch allowing DSA core to report locked entries to the bridge > driver 2. This requires no code in the DSA layer as the bridge listens directly to the kernel switchdev notifications. > > 3. A patch adding the new MAB flag to BR_PORT_FLAGS_HW_OFFLOAD > > 4. A patch allowing DSA core to propagate the MAB flag to device > drivers > > [...] > >> diff --git a/net/dsa/port.c b/net/dsa/port.c >> index e4a0513816bb..eab32b7a945a 100644 >> --- a/net/dsa/port.c >> +++ b/net/dsa/port.c >> @@ -304,7 +304,7 @@ static int dsa_port_inherit_brport_flags(struct >> dsa_port *dp, >> struct netlink_ext_ack *extack) >> { >> const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD | >> - BR_BCAST_FLOOD | BR_PORT_LOCKED; >> + BR_BCAST_FLOOD; > > Not sure how this is related to the patchset. > >> struct net_device *brport_dev = dsa_port_to_bridge_port(dp); >> int flag, err;