From: Nikolay Aleksandrov <razor@blackwall.org>
To: Ido Schimmel <idosch@nvidia.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: mlxsw@nvidia.com, edumazet@google.com, roopa@nvidia.com,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next v2 1/9] bridge: mcast: Centralize netlink attribute parsing
Date: Tue, 6 Dec 2022 14:32:01 +0200 [thread overview]
Message-ID: <35aefd47-937d-c4c9-8cab-697ea07d098f@blackwall.org> (raw)
In-Reply-To: <20221206105809.363767-2-idosch@nvidia.com>
On 06/12/2022 12:58, Ido Schimmel wrote:
> Netlink attributes are currently passed deep in the MDB creation call
> chain, making it difficult to add new attributes. In addition, some
> validity checks are performed under the multicast lock although they can
> be performed before it is ever acquired.
>
> As a first step towards solving these issues, parse the RTM_{NEW,DEL}MDB
> messages into a configuration structure, relieving other functions from
> the need to handle raw netlink attributes.
>
> Subsequent patches will convert the MDB code to use this configuration
> structure.
>
> This is consistent with how other rtnetlink objects are handled, such as
> routes and nexthops.
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
>
> Notes:
> v2:
> * Remove 'skb' argument from br_mdb_config_init()
> * Mark 'nlh' argument as 'const'.
>
Thanks,
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2022-12-06 12:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 10:58 [Bridge] [PATCH net-next v2 0/9] bridge: mcast: Preparations for EVPN extensions Ido Schimmel
2022-12-06 10:58 ` [Bridge] [PATCH net-next v2 1/9] bridge: mcast: Centralize netlink attribute parsing Ido Schimmel
2022-12-06 12:32 ` Nikolay Aleksandrov [this message]
2022-12-06 10:58 ` [Bridge] [PATCH net-next v2 2/9] bridge: mcast: Remove redundant checks Ido Schimmel
2022-12-06 10:58 ` [Bridge] [PATCH net-next v2 3/9] bridge: mcast: Use MDB configuration structure where possible Ido Schimmel
2022-12-06 10:58 ` [Bridge] [PATCH net-next v2 4/9] bridge: mcast: Propagate MDB configuration structure further Ido Schimmel
2022-12-06 10:58 ` [Bridge] [PATCH net-next v2 5/9] bridge: mcast: Use MDB group key from configuration structure Ido Schimmel
2022-12-06 10:58 ` [Bridge] [PATCH net-next v2 6/9] bridge: mcast: Remove br_mdb_parse() Ido Schimmel
2022-12-06 10:58 ` [Bridge] [PATCH net-next v2 7/9] bridge: mcast: Move checks out of critical section Ido Schimmel
2022-12-06 10:58 ` [Bridge] [PATCH net-next v2 8/9] bridge: mcast: Remove redundant function arguments Ido Schimmel
2022-12-06 10:58 ` [Bridge] [PATCH net-next v2 9/9] bridge: mcast: Constify 'group' argument in br_multicast_new_port_group() Ido Schimmel
2022-12-06 12:32 ` Nikolay Aleksandrov
2022-12-08 4:10 ` [Bridge] [PATCH net-next v2 0/9] bridge: mcast: Preparations for EVPN extensions patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35aefd47-937d-c4c9-8cab-697ea07d098f@blackwall.org \
--to=razor@blackwall.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox