Ethernet Bridge development
 help / color / mirror / Atom feed
From: shenry82 <shenry82@voila.fr>
To: Bridge@lists.osdl.org
Subject: [Bridge] Timer problem
Date: Tue, 26 Jul 2005 16:10:30 +0200 (CEST)	[thread overview]
Message-ID: <4391574.1122387030898.JavaMail.www@wwinf4103> (raw)

Hi all,

    I try to reduce the time of link break detection for the STP. I want to make a timer who detect a link failure
within a few times instead of waiting max age timeout. The problem is that my timer isn't take in account by the bride and i really don't know why, can someone help me ?
Here's what I've done :

in file br_stp_timer.c :

/* called under bridge lock */
static void br_loss_timer_expired(struct net_bridge_port *p)
{	
	printk(KERN_INFO "il y a perte de connection \n");
	br_timer_set(&p->loss_timer, jiffies); // for the moment I just want my function to be take in account.
}

/* called under bridge lock */
static void br_check_port_timers(struct net_bridge_port *p)
{
	if (br_timer_has_expired(&p->message_age_timer, p->br->max_age)) {
		br_timer_clear(&p->message_age_timer);
		br_message_age_timer_expired(p);
	}

	if (br_timer_has_expired(&p->forward_delay_timer, p->br->forward_delay)) {
		br_timer_clear(&p->forward_delay_timer);
		br_forward_delay_timer_expired(p);
	}

	if (br_timer_has_expired(&p->hold_timer, BR_HOLD_TIME)) {
		br_timer_clear(&p->hold_timer);
		br_hold_timer_expired(p);
	}

	if (br_timer_has_expired(&p->loss_timer, (1*HZ)))  // This condition is never true !?
	{
		printk(KERN_INFO "On a perdu la connection \n");
		br_timer_clear(&p->loss_timer);
		br_loss_timer_expired(p);
	}

}

I also tried to check if my timer is running with br_timer_is_running(&p->loss_timer) but it's also never true.

Thanks for your help,

HENRY Simon

PS : if someone tried to implement RSTP with brctl and succeed I'm interest in ^^
------------------------------------------

Faites un voeu et puis Voila ! www.voila.fr 




                 reply	other threads:[~2005-07-26 14:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4391574.1122387030898.JavaMail.www@wwinf4103 \
    --to=shenry82@voila.fr \
    --cc=Bridge@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox