From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5335540483 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 943A340155 MIME-Version: 1.0 Date: Fri, 08 Jul 2022 11:27:15 +0200 From: netdev@kapio-technology.com In-Reply-To: <20220708091550.2qcu3tyqkhgiudjg@skbuf> References: <20220707152930.1789437-1-netdev@kapio-technology.com> <20220707152930.1789437-4-netdev@kapio-technology.com> <20220708084904.33otb6x256huddps@skbuf> <20220708091550.2qcu3tyqkhgiudjg@skbuf> Message-ID: <463ead20c286688abc9800e487558a3b@kapio-technology.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v4 net-next 3/6] drivers: net: dsa: add locked fdb entry flag to drivers List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Oltean Cc: Ivan Vecera , Andrew Lunn , Florian Fainelli , Jiri Pirko , Daniel Borkmann , netdev@vger.kernel.org, Nikolay Aleksandrov , bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Ido Schimmel , Vivien Didelot , Eric Dumazet , linux-kselftest@vger.kernel.org, Roopa Prabhu , kuba@kernel.org, Paolo Abeni , Shuah Khan , davem@davemloft.net On 2022-07-08 11:15, Vladimir Oltean wrote: > > Well, yes, but if I'm correct, the bridge right now can't create locked > FDB entries, so is_locked will always be false in the ADD_TO_DEVICE > direction. The bridge can create locked FDB entries with this patch set. That is part of the idea that a SW bridge will have the same features as the HW version, so first I made it in the bridge. > > When the possibility for it to be true will exist, _all_ switchdev > drivers will need to be updated to ignore that (mlxsw, cpss, ocelot, > rocker, prestera, etc etc), not just DSA. And you don't need to > propagate the is_locked flag to all individual DSA sub-drivers when > none > care about is_locked in the ADD_TO_DEVICE direction, you can just > ignore > within DSA until needed otherwise. >