From: Cameron Schaus <cam@schaus.ca>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: bridge@linux-foundation.org
Subject: Re: [Bridge] VLAN header accounting for packets leaving bridge
Date: Mon, 30 Jul 2007 11:36:36 -0600 [thread overview]
Message-ID: <46AE21A4.4000501@schaus.ca> (raw)
In-Reply-To: <20070730181137.2bf6a4e8@oldman>
Stephen Hemminger wrote:
> This might break VLAN transparent bridging (ie. when eth0 is bridged to eth1
> and the bridge doesn't know or care about vlan's). There is also the case
> where packet comes in over VLAN and goes out without tag.
>
I was definitely worried about the first case you mentioned. However,
the nf_bridge_copy_header function does the same skb_push taking into
account the 8021Q header size, if it's called.
In light of the cases you mentioned above, would it be best to just
alter the data pointer in the ebtables module to take into account the
new vlan header? I hesitate to do this because doing so could affect
other rules run after the modification, if any.
Cam
prev parent reply other threads:[~2007-07-30 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 16:48 [Bridge] VLAN header accounting for packets leaving bridge Cameron Schaus
2007-07-30 17:11 ` Stephen Hemminger
2007-07-30 17:30 ` Ben Greear
2007-07-30 17:36 ` Cameron Schaus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AE21A4.4000501@schaus.ca \
--to=cam@schaus.ca \
--cc=bridge@linux-foundation.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox