Ethernet Bridge development
 help / color / mirror / Atom feed
From: Saikiran Madugula <hummerbliss@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Stephen Hemminger <shemminger@vyatta.com>, bridge@linuxfoundation.org
Subject: Re: [Bridge] 802.1q packets
Date: Tue, 17 Mar 2009 16:26:39 +0000	[thread overview]
Message-ID: <49BFCF3F.5020103@gmail.com> (raw)
In-Reply-To: <49BFBA86.2050603@gmail.com>

Saikiran Madugula wrote:
> Patrick McHardy wrote:
>> richardvoigt@gmail.com wrote:
>>> On Mon, Jun 30, 2008 at 5:07 PM, Fulvio Ricciardi <
>>> fulvio.ricciardi@zeroshell.net> wrote:
>>>
>>>>> That mostly rules out other devices in the path as the
>>>>> cause of the problem.  There's just one chance of a
>>>>> netfilter interaction that I can think of: netfilter may
>>>>> cause fragments to be recombined, without netfilter the
>>>>> fragments could be bridged.  Are you running the ping
>>>>> command from the bridge itself, or across the bridge? (I
>>>>> presume across the bridge because you are discussing the
>>>>> FORWARD chain only)
>>>> I ping across the bridge. If instead a ping from the bridge
>>>> itself, all works right.
>>>>
>>>>> Do the large ping requests show up in the iptables
>>>>> counters?
>>>> Yes, in any case (either ping -s 1472 and ping -s 1473) the
>>>> packets are counted in the FORWARD chain.
>>>>
>>>>> What happens if you set no fragmentation when you run
>>>>> ping?
>>>> it's the same
>>>
>>> Just to verify, you mean that with no fragmentation, large pings go 
>>> through
>>> if and only if bridge-nf-call-iptables is disabled?
>>
>>
>> Just FYI for all affected, I'm looking into this. One
>> problem is that only packets with skb->protocol == ETH_P_IP
>> are refragmented, but not ETH_P_8021Q. That change alone
>> doesn't fix it though, still trying to track it down.
>>
> 
> Is this problem fixed ? I am unable to find if this problem is fixed in 
> later commits in the tree.
> 

I realized that commit (fbd8104c2eb2f00a031a3e472a0fc08e40d04c0b) disables 
bridge netfilter code on PPOE and VLAN tagged frames entirely. Is it because the 
problem mentioned in the above thread still there ?

  reply	other threads:[~2009-03-17 16:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30 17:07 [Bridge] 802.1q packets Fulvio Ricciardi
2008-06-30 22:42 ` richardvoigt
2008-07-01 15:10   ` Patrick McHardy
2009-03-17 14:58     ` Saikiran Madugula
2009-03-17 16:26       ` Saikiran Madugula [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-07-22 17:40 Fulvio Ricciardi
2008-07-22 19:35 ` Adam Osuchowski
2008-07-22 21:59   ` Stephen Hemminger
2008-07-23  3:51     ` richardvoigt
2008-09-20 20:47     ` Adam Osuchowski
2008-06-30 16:58 Fulvio Ricciardi
2008-06-30  5:53 Leigh Sharpe
2008-06-28 21:17 Fulvio Ricciardi
2008-06-29  0:08 ` richardvoigt
2008-06-28 19:50 Fulvio Ricciardi
2008-06-28 21:06 ` richardvoigt
2008-06-28 12:07 Fulvio Ricciardi
2008-06-28 18:31 ` Stephen Hemminger
2008-06-28  4:56 Fulvio Ricciardi
2008-07-22 11:09 ` Adam Osuchowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49BFCF3F.5020103@gmail.com \
    --to=hummerbliss@gmail.com \
    --cc=bridge@linuxfoundation.org \
    --cc=kaber@trash.net \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox