From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <49D0BF7F.1060305@trash.net> Date: Mon, 30 Mar 2009 14:47:59 +0200 From: Patrick McHardy MIME-Version: 1.0 References: <20090326155205.GA28868@psychotron.englab.brq.redhat.com> <20090327.003819.234492275.davem@davemloft.net> <49CC85E9.7070903@trash.net> <20090329.135355.109115565.davem@davemloft.net> <49D0B549.3050900@trash.net> <20090330124049.GD3438@psychotron.englab.brq.redhat.com> In-Reply-To: <20090330124049.GD3438@psychotron.englab.brq.redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH] bonding: allow bond in mode balance-alb to work properly in bridge -try4 List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jiri Pirko Cc: fubar@us.ibm.com, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, mschmidt@redhat.com, bonding-devel@lists.sourceforge.net, jgarzik@pobox.com, dada1@cosmosbay.com, David Miller Jiri Pirko wrote: > Currently I'm thinking the way. What I have on mind: > I would like to add a list into struct net_device to contain all mac addresses > of the device. I would also like to use similar interface to handle them as > currently is for uc_list and mc_list. However I do not like that these lists are > not using standard list_head but they are propriate lists only for this purpose. > I'm thinking about converting them to use list_head first. Or maybe ignore them > and do the new list for macs in parallel? Using list_heads in the address lists would require some pretty large amount of work since you'd need to convert all the drivers. I'm all in favour of doing this, but I wouldn't make the fix depend on that work.