From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4A967DAB.2010209@voltaire.com> Date: Thu, 27 Aug 2009 15:35:55 +0300 From: Or Gerlitz MIME-Version: 1.0 References: <000001ca17a3$03f841f0$0be8c5d0$@edu> <20090807143652.1659ac57@nehalam> <4A7EB0AC.2030104@Voltaire.com> <20090810082037.17b352c2@nehalam> In-Reply-To: <20090810082037.17b352c2@nehalam> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [evb] RE: [PATCH][RFC] net/bridge: add basic VEPA support List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stephen Hemminger Cc: "evb@yahoogroups.com" , arnd@arndb.de, anna.fischer@hp.com, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, adobriyan@gmail.com, "Paul Congdon (UC Davis)" , virtualization@lists.linux-foundation.org, davem@davemloft.net Stephen Hemminger wrote: > Or Gerlitz wrote: >> Looking in macvlan_set_multicast_list() it acts in a similar manner to macvlan_set_mac_address() in the sense that it calls dev_mc_sync(). I assume what's left is to add macvlan_hash_xxx multicast logic to map/unmap multicast groups to what macvlan devices want to receive them and this way the flooding can be removed, correct? > The device can just flood all multicast packets, since the filtering is done on the receive path anyway. for each multicast packet, macvlan_broadcast is invoked and calls skb_clone/ netif_rx for each device, now a smart scheme that takes into account (hash) the multicast list of the different macvlan devices would save the skb_clone call, isn't it? Or.