From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4B055A9B.1090502@trash.net> Date: Thu, 19 Nov 2009 15:47:55 +0100 From: Patrick McHardy MIME-Version: 1.0 References: <1258497551-25959-1-git-send-email-arnd@arndb.de> <200911182332.56309.arnd@arndb.de> <200911191244.43916.arnd@arndb.de> In-Reply-To: <200911191244.43916.arnd@arndb.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH 1/3] macvlan: Reflect macvlan packets meant for other macvlan devices List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Arnd Bergmann Cc: virtualization@linux-foundation.com, Herbert Xu , Eric Dumazet , Anna Fischer , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Gerhard Stenzel , "Eric W. Biederman" , Jens Osterkamp , Patrick Mullaney , Stephen Hemminger , Edge Virtual Bridging , David Miller Arnd Bergmann wrote: > On Thursday 19 November 2009, Eric W. Biederman wrote: >>> It seems that we should never drop dst then. We either forward the frame to >>> netif_rx or to dev_queue_xmit, and from how I read it now, we want to keep >>> the dst in both cases. >> When we loop back on our selves we certainly need to have dst clear because >> we don't know how to cache routes through multiple network namespaces. > > Ah, right. So should I add the explicit dst_drop to the new dev_forward_skb() > then? The veth driver doesn't need it, but it also looks like it won't hurt. Yes, I think that should be fine.