From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4B8F3056.1010109@oracle.com> Date: Wed, 03 Mar 2010 20:00:22 -0800 From: Randy Dunlap MIME-Version: 1.0 References: <20100302180915.1388d3f3.sfr@canb.auug.org.au> <4B8D4607.8070603@xenotime.net> <20100303.012359.66790294.davem@davemloft.net> <20100304031847.GA22683@elte.hu> In-Reply-To: <20100304031847.GA22683@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH -next] bridge: depends on INET List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ingo Molnar Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, David Miller On 03/03/10 19:18, Ingo Molnar wrote: > > * David Miller wrote: > >> From: Randy Dunlap >> Date: Tue, 02 Mar 2010 09:08:23 -0800 >> >>> From: Randy Dunlap >>> >>> br_multicast calls ip_send_check(), so it should depend on INET. >>> >>> built-in: >>> br_multicast.c:(.text+0x88cf4): undefined reference to `ip_send_check' >>> >>> or modular: >>> ERROR: "ip_send_check" [net/bridge/bridge.ko] undefined! >>> >>> Signed-off-by: Randy Dunlap >> >> Applied, but I almost lost this patch. >> >> You need to CC: netdev on all networking patches so that it >> gets properly tracked in patchwork and therefore does not get >> lost. > > I suspect Randy went by the MAINTAINERS entry - you might want to add netdev > as a second 'L:' line: > > ETHERNET BRIDGE > M: Stephen Hemminger > L: bridge@lists.linux-foundation.org > W: http://www.linux-foundation.org/en/Net:Bridge > S: Maintained > F: include/linux/netfilter_bridge/ > F: net/bridge/ > > To make it really clear that netdev must be Cc:-ed for those patches. Ack that. I also expected Stephen to merge it... -- ~Randy