From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4BA82186.3010204@redhat.com> Date: Tue, 23 Mar 2010 10:03:50 +0800 From: Cong Wang MIME-Version: 1.0 References: <20100322082059.4967.63492.sendpatchset@localhost.localdomain> <20100322082112.4967.5504.sendpatchset@localhost.localdomain> <1269297307.3552.23.camel@calx> In-Reply-To: <1269297307.3552.23.camel@calx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [RFC Patch 2/3] bridge: make bridge support netpoll List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matt Mackall Cc: Jay Vosburgh , Neil Horman , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, David Miller , Andy Gospodarek , bonding-devel@lists.sourceforge.net Matt Mackall wrote: > On Mon, 2010-03-22 at 04:17 -0400, Amerigo Wang wrote: >> Based on the previous patch, make bridge support netpoll by: >> >> 1) implement the 4 methods to support netpoll for bridge; >> >> 2) modify netpoll during forwarding packets in bridge; >> >> 3) disable netpoll support of bridge when a netpoll-unabled device >> is added to bridge; > > Not sure if this is the right thing to do. Shouldn't we simply enable > polling on all devices that support it and warn about the others (aka > best effort)? > I don't think it's a good idea, because we check if a device supports netpoll by checking if it has ndo_poll_controller method. Thanks.