From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4E65C326.3010506@broadcom.com> Date: Mon, 5 Sep 2011 23:52:22 -0700 From: "Bhanu Prakash Gollapudi" MIME-Version: 1.0 References: <1314905304-16485-1-git-send-email-jpirko@redhat.com> <20110902122630.GC1991@minipsycho> <1314989161.3419.5.camel@bwh-desktop> <20110903133428.GA2821@minipsycho> <1315057614.3092.160.camel@deadeye> <5A9BD224CEA58D4CB62235967D650C160A1B7D1C@orsmsx509.amr.corp.intel.com> In-Reply-To: <5A9BD224CEA58D4CB62235967D650C160A1B7D1C@orsmsx509.amr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [patch net-next-2.6 v3] net: consolidate and fix ethtool_ops->get_settings calling List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Zou, Yi" Cc: "amit.salecha@qlogic.com" , "bridge@lists.linux-foundation.org" , "linux-mips@linux-mips.org" , "devel@open-fcoe.org" , "linux-scsi@vger.kernel.org" , "decot@google.com" , "therbert@google.com" , "eric.dumazet@gmail.com" , "fubar@us.ibm.com" , "JBottomley@parallels.com" , "xiaosuo@gmail.com" , "paulmck@linux.vnet.ibm.com" , "Duyck, Alexander H" , "mirq-linux@rere.qmqm.pl" , Ben Hutchings , "greearb@candelatech.com" , "Love, Robert W" , "laijs@cn.fujitsu.com" , Jiri Pirko , "netdev@vger.kernel.org" , "ralf@linux-mips.org" , "davem@davemloft.net" , "loke.chetan@gmail.com" On 9/5/2011 8:25 PM, Zou, Yi wrote: >> >> On Sat, 2011-09-03 at 15:34 +0200, Jiri Pirko wrote: >>> This patch does several things: >>> - introduces __ethtool_get_settings which is called from ethtool code >> and >>> from drivers as well. Put ASSERT_RTNL there. >>> - dev_ethtool_get_settings() is replaced by __ethtool_get_settings() >>> - changes calling in drivers so rtnl locking is respected. In >>> iboe_get_rate was previously ->get_settings() called unlocked. This >>> fixes it. Also prb_calc_retire_blk_tmo() in af_packet.c had the same >>> problem. Also fixed by calling __dev_get_by_index() instead of >>> dev_get_by_index() and holding rtnl_lock for both calls. >>> - introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create() >>> so bnx2fc_if_create() and fcoe_if_create() are called locked as they >>> are from other places. >>> - use __ethtool_get_settings() in bonding code >>> >>> Signed-off-by: Jiri Pirko >> Reviewed-by: Ben Hutchings [except FCoE bits] >> >> Ben. > FCoE bits look ok to me. Thanks, > > Reviewed-by: Yi Zou bnx2fc changes looks OK to me. Reviewed-by: Bhanu Prakash Gollapudi > >> >> -- >> Ben Hutchings, Staff Engineer, Solarflare >> Not speaking for my employer; that's the marketing department's job. >> They asked us to note that Solarflare product names are trademarked. >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html