From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4EB195EA.4050100@parallels.com> From: Vasily Averin MIME-Version: 1.0 References: <4EB19549.4010601@parallels.com> In-Reply-To: <4EB19549.4010601@parallels.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish() List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Wed, 02 Nov 2011 19:11:11 -0000 Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, Herbert Xu , Stephen Hemminger , "David S. Miller" , devel@openvz.org On 11/02/2011 11:08 PM, Vasily Averin wrote: > if dst is not local br_handle_frame_finish() does not clone original skb and > forgets to reset IPCB before return to IP stack. it can lead to stack corruption > in icmp_send() example of stack corruption http://bugzilla.openvz.org/show_bug.cgi?id=2016 > Signed-off-by: Vasily Averin > --- > net/bridge/br_input.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c > index f06ee39..6be8d00 100644 > --- a/net/bridge/br_input.c > +++ b/net/bridge/br_input.c > @@ -93,10 +93,11 @@ int br_handle_frame_finish(struct sk_buff *skb) > skb2 = skb; > > br->dev->stats.multicast++; > - } else if ((dst = __br_fdb_get(br, dest)) && dst->is_local) { > + } else if ((dst = __br_fdb_get(br, dest)) != NULL) { > skb2 = skb; > /* Do not forward the packet since it's local. */ > - skb = NULL; > + if (dst->is_local) { > + skb = NULL; > } > > if (skb) { > -- 1.7.5.4