From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4F56208E.2090801@gmail.com> Date: Tue, 06 Mar 2012 16:34:54 +0200 From: Paulius Zaleckas MIME-Version: 1.0 References: <20120306142219.31783.30201.stgit@localhost.localdomain> In-Reply-To: <20120306142219.31783.30201.stgit@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH] bridge: fix "entering disabled state" logging List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "netdev@vger.kernel.org" , bridge@lists.linux-foundation.org On 03/06/2012 04:22 PM, Paulius Zaleckas wrote: > Now we have: > eth0: link down > br0: port 1(eth0) entering forwarding state > > State should be logged *after* it was changed, not before. The funny thing is that it was introduced: 2010-05-16 stephen hemminger bridge: change console message interface 28a16c97963d3bc36a2c192859f6d8025ef2967a and no one noticed since then :D