From: Nikolay Aleksandrov <razor@blackwall.org>
To: Petr Machata <petrm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org
Cc: Ido Schimmel <idosch@nvidia.com>,
bridge@lists.linux.dev, mlxsw@nvidia.com,
Amit Cohen <amcohen@nvidia.com>
Subject: Re: [PATCH net-next 2/2] selftests: test_bridge_neigh_suppress: Test unicast ARP/NS with suppression
Date: Wed, 9 Apr 2025 13:33:37 +0300 [thread overview]
Message-ID: <4ee836f0-9d28-4e40-bcca-1b4eadd040f3@blackwall.org> (raw)
In-Reply-To: <dc240b9649b31278295189f412223f320432c5f2.1744123493.git.petrm@nvidia.com>
On 4/8/25 18:40, Petr Machata wrote:
> From: Amit Cohen <amcohen@nvidia.com>
>
> Add test cases to check that unicast ARP/NS packets are replied once, even
> if ARP/ND suppression is enabled.
>
> Without the previous patch:
> $ ./test_bridge_neigh_suppress.sh
> ...
> Unicast ARP, per-port ARP suppression - VLAN 10
> -----------------------------------------------
> TEST: "neigh_suppress" is on [ OK ]
> TEST: Unicast ARP, suppression on, h1 filter [FAIL]
> TEST: Unicast ARP, suppression on, h2 filter [ OK ]
>
> Unicast ARP, per-port ARP suppression - VLAN 20
> -----------------------------------------------
> TEST: "neigh_suppress" is on [ OK ]
> TEST: Unicast ARP, suppression on, h1 filter [FAIL]
> TEST: Unicast ARP, suppression on, h2 filter [ OK ]
> ...
> Unicast NS, per-port NS suppression - VLAN 10
> ---------------------------------------------
> TEST: "neigh_suppress" is on [ OK ]
> TEST: Unicast NS, suppression on, h1 filter [FAIL]
> TEST: Unicast NS, suppression on, h2 filter [ OK ]
>
> Unicast NS, per-port NS suppression - VLAN 20
> ---------------------------------------------
> TEST: "neigh_suppress" is on [ OK ]
> TEST: Unicast NS, suppression on, h1 filter [FAIL]
> TEST: Unicast NS, suppression on, h2 filter [ OK ]
> ...
> Tests passed: 156
> Tests failed: 4
>
> With the previous patch:
> $ ./test_bridge_neigh_suppress.sh
> ...
> Unicast ARP, per-port ARP suppression - VLAN 10
> -----------------------------------------------
> TEST: "neigh_suppress" is on [ OK ]
> TEST: Unicast ARP, suppression on, h1 filter [ OK ]
> TEST: Unicast ARP, suppression on, h2 filter [ OK ]
>
> Unicast ARP, per-port ARP suppression - VLAN 20
> -----------------------------------------------
> TEST: "neigh_suppress" is on [ OK ]
> TEST: Unicast ARP, suppression on, h1 filter [ OK ]
> TEST: Unicast ARP, suppression on, h2 filter [ OK ]
> ...
> Unicast NS, per-port NS suppression - VLAN 10
> ---------------------------------------------
> TEST: "neigh_suppress" is on [ OK ]
> TEST: Unicast NS, suppression on, h1 filter [ OK ]
> TEST: Unicast NS, suppression on, h2 filter [ OK ]
>
> Unicast NS, per-port NS suppression - VLAN 20
> ---------------------------------------------
> TEST: "neigh_suppress" is on [ OK ]
> TEST: Unicast NS, suppression on, h1 filter [ OK ]
> TEST: Unicast NS, suppression on, h2 filter [ OK ]
> ...
> Tests passed: 160
> Tests failed: 0
>
> Signed-off-by: Amit Cohen <amcohen@nvidia.com>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> ---
> .../net/test_bridge_neigh_suppress.sh | 125 ++++++++++++++++++
> 1 file changed, 125 insertions(+)
>
Thanks,
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2025-04-09 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 15:40 [PATCH net-next 0/2] bridge: Prevent unicast ARP/NS packets from being suppressed by bridge Petr Machata
2025-04-08 15:40 ` [PATCH net-next 1/2] net: " Petr Machata
2025-04-09 10:33 ` Nikolay Aleksandrov
2025-04-08 15:40 ` [PATCH net-next 2/2] selftests: test_bridge_neigh_suppress: Test unicast ARP/NS with suppression Petr Machata
2025-04-09 10:33 ` Nikolay Aleksandrov [this message]
2025-04-10 2:30 ` [PATCH net-next 0/2] bridge: Prevent unicast ARP/NS packets from being suppressed by bridge patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ee836f0-9d28-4e40-bcca-1b4eadd040f3@blackwall.org \
--to=razor@blackwall.org \
--cc=amcohen@nvidia.com \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox