From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <530E25CC.6010705@redhat.com> Date: Wed, 26 Feb 2014 12:35:08 -0500 From: Vlad Yasevich MIME-Version: 1.0 References: <1393427905-6811-1-git-send-email-vyasevic@redhat.com> <1393427905-6811-4-git-send-email-vyasevic@redhat.com> <20140226085707.55bdab94@nehalam.linuxnetplumber.net> In-Reply-To: <20140226085707.55bdab94@nehalam.linuxnetplumber.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH 3/7] bridge: Add addresses from static fdbs to bridge address list Reply-To: vyasevic@redhat.com List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stephen Hemminger Cc: mst@redhat.com, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, jhs@mojatatu.com, john.r.fastabend@intel.com, shemminger@vyatta.com On 02/26/2014 11:57 AM, Stephen Hemminger wrote: > On Wed, 26 Feb 2014 10:18:21 -0500 > Vlad Yasevich wrote: > >> When a static fdb entry is created, add the mac address to the bridge >> address list. This list is used to program the proper port's >> address list. >> >> Signed-off-by: Vlad Yasevich > > I don't like this level of bookkeeping it starts to mix > layers between the bridge network interface as entity for talking to the > local host, and forwarding table entries. Actually this is one of the reasons this isn't done through the br->dev->uc. Forwarding table entries are still per-port. > > Many times static entries are used as alternative to flooding in > environments which don't trust STP. Ok, and how would this be problematic? If one wants to turn off promisc in this environment, then receive filters needs to be properly programmed. > > Plus, it looks like another major source of bugs. > Any new code is a potential source of issues. Are you saying No to any new code in bridge? -vlad