From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <542EA7A8.1070701@redhat.com> Date: Fri, 03 Oct 2014 09:42:00 -0400 From: Vlad Yasevich MIME-Version: 1.0 References: <1412294070-11930-1-git-send-email-vyasevic@redhat.com> <1412294070-11930-2-git-send-email-vyasevic@redhat.com> <542DF6FA.4050107@lab.ntt.co.jp> In-Reply-To: <542DF6FA.4050107@lab.ntt.co.jp> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v3 net-next 1/3] bridge: Add a default_pvid sysfs attribute Reply-To: vyasevic@redhat.com List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Toshiaki Makita , Vladislav Yasevich , netdev@vger.kernel.org Cc: stephen@networkplumber.org, bridge@lists.linux-foundation.org On 10/02/2014 09:08 PM, Toshiaki Makita wrote: > On 2014/10/03 8:54, Vladislav Yasevich wrote: >> This patch allows the user to set and retrieve default_pvid >> value. A new value can only be stored when vlan filtering >> is disabled. >> >> Signed-off-by: Vladislav Yasevich >> --- > ... >> +int br_vlan_set_default_pvid(struct net_bridge *br, unsigned long val) >> +{ >> + u16 pvid = val; >> + int err = 0; >> + >> + if (!val || val >= VLAN_VID_MASK) >> + return -EINVAL; >> + >> + if (!rtnl_trylock()) >> + return restart_syscall(); >> + >> + if (pvid == br->default_pvid) >> + goto unlock; >> + >> + /* Only allow default pvid change when filtering is disabled */ >> + if (br->vlan_enabled) { >> + pr_info_once("Please disable vlan filtering to change default_pvid\n"); >> + err = -EPERM; >> + goto unlock; >> + } >> + >> + br->default_pvid = vid; > > typo: s/vid/pvid/ How the hell did this even build then...! Oh, the last patch moved it elsewhere and fixed it. Fixed. Thanks -vlad > > Thanks, > Toshiaki Makita >