From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <toshiaki.makita1@gmail.com>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=+SghU9lRSjVwKAfuzNO3NadwXID9yULkD1H/6wcOLLk=;
	b=YADjcumrb4ZCV94IhpB1wGc1F9gVX85mxYXwg2IFBCvK9msHm7w98VGSeR9XUidPOm
	TPjsFfXkFBUnwYJegAvUat3DS30KgoydGx+6WvWxTv8BxisIBgPGynOo04kZ7gWn8uC2
	BOKLYz+WpQPgbXN1YNz3riiOEoMni3Shk4hKYHvXwoQqv0G4dyCBkat+Q4UmC4/Q9mIT
	OtAMFGfJ5vJU72ZYyotthXiHFrzKb2q1q34rv8fb5591TZkh/FLtOySijSRz2MyLBRjy
	hKI1VbJAnlLWeNLMm7PIhykYonHCeeBBgy2D5x38iUGDhTz1XsP89Hh23xhva2a9sx2P
	fnlw==
Message-ID: <542EB326.50006@gmail.com>
Date: Fri, 03 Oct 2014 23:31:02 +0900
From: Toshiaki Makita <toshiaki.makita1@gmail.com>
MIME-Version: 1.0
References: <1412294070-11930-1-git-send-email-vyasevic@redhat.com>
	<1412294070-11930-2-git-send-email-vyasevic@redhat.com>
	<542DF6FA.4050107@lab.ntt.co.jp> <542EA7A8.1070701@redhat.com>
In-Reply-To: <542EA7A8.1070701@redhat.com>
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Subject: Re: [Bridge] [PATCH v3 net-next 1/3] bridge: Add a default_pvid
	sysfs attribute
List-Id: Linux Ethernet Bridging <bridge.lists.linux-foundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bridge>, 
	<mailto:bridge-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bridge/>
List-Post: <mailto:bridge@lists.linux-foundation.org>
List-Help: <mailto:bridge-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bridge>,
	<mailto:bridge-request@lists.linux-foundation.org?subject=subscribe>
To: vyasevic@redhat.com, Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>, Vladislav Yasevich <vyasevich@gmail.com>, netdev@vger.kernel.org
Cc: stephen@networkplumber.org, bridge@lists.linux-foundation.org

(14/10/03 (金) 22:42), Vlad Yasevich wrote:
> On 10/02/2014 09:08 PM, Toshiaki Makita wrote:
>> On 2014/10/03 8:54, Vladislav Yasevich wrote:
>>> This patch allows the user to set and retrieve default_pvid
>>> value.  A new value can only be stored when vlan filtering
>>> is disabled.
>>>
>>> Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
>>> ---
>> ...
>>> +int br_vlan_set_default_pvid(struct net_bridge *br, unsigned long val)
>>> +{
>>> +	u16 pvid = val;
>>> +	int err = 0;
>>> +
>>> +	if (!val || val >= VLAN_VID_MASK)
>>> +		return -EINVAL;
>>> +
>>> +	if (!rtnl_trylock())
>>> +		return restart_syscall();
>>> +
>>> +	if (pvid == br->default_pvid)
>>> +		goto unlock;
>>> +
>>> +	/* Only allow default pvid change when filtering is disabled */
>>> +	if (br->vlan_enabled) {
>>> +		pr_info_once("Please disable vlan filtering to change default_pvid\n");
>>> +		err = -EPERM;
>>> +		goto unlock;
>>> +	}
>>> +
>>> +	br->default_pvid = vid;
>>
>> typo: s/vid/pvid/
> 
> How the hell did this even build then...!  Oh,  the last patch moved it elsewhere and
> fixed it.
> 
> Fixed.

This can break bisect, so I think this patch itself should be fixed.

Thanks,
Toshiaki Makita