From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <565B7F7D.80208@nod.at> <87egf7183c.fsf_-_@x220.int.ebiederm.org> From: Richard Weinberger Message-ID: <565CD459.6010402@nod.at> Date: Mon, 30 Nov 2015 23:57:29 +0100 MIME-Version: 1.0 In-Reply-To: <87egf7183c.fsf_-_@x220.int.ebiederm.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Eric W. Biederman" , David Miller Cc: Kees Cook , "kernel-hardening@lists.openwall.com" , "netdev@vger.kernel.org" , bridge@lists.linux-foundation.org, "linux-kernel@vger.kernel.org" Am 30.11.2015 um 22:38 schrieb Eric W. Biederman: > > There is no defined mechanism to pass network namespace information > into /sbin/bridge-stp therefore don't even try to invoke it except > for bridge devices in the initial network namespace. > > It is possible for unprivileged users to cause /sbin/bridge-stp to be > invoked for any network device name which if /sbin/bridge-stp does not > guard against unreasonable arguments or being invoked twice on the same > network device could cause problems. > > Signed-off-by: "Eric W. Biederman" Just figured that /sbin/bridge-stp is a shell script. Network interfaces can contain a lot of funny characters, maybe this is after all a security issue. Thanks, //richard