From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=0/+YXrYJVptiMtRjCeYcHIr9ur1WtmvUO954r2m+C7E=; b=gPTP6aFv5fWNz6sSQ2xkx3Kk5RGm+qPwLk87/j5hFjgqyDof75L408qKBl9Cmps/v7 pCdPdYNShFqE3CjMIrnB4R2sjEsGj6HFKs03DoyJygiRGG30h1yMwkOkucECwQp8ZL6Q BepfoW+6vzRBIycakE9/yCQVyRRERO/qh26Gs= References: <6e2cf6821542a253904dfc7d8ec431d6bbda2b4e.1460131308.git.lucien.xin@gmail.com> <6197a35a2eb6df2caf90edcbf1b49da12077f659.1460131308.git.lucien.xin@gmail.com> <8c14a891d0a8bcea071d4e5305776a5c5cd9fd17.1460131308.git.lucien.xin@gmail.com> <1dd5e14c7f042753a4d70b585de407a4e388262a.1460131308.git.lucien.xin@gmail.com> From: Nikolay Aleksandrov Message-ID: <5708F866.9060302@cumulusnetworks.com> Date: Sat, 9 Apr 2016 14:41:10 +0200 MIME-Version: 1.0 In-Reply-To: <1dd5e14c7f042753a4d70b585de407a4e388262a.1460131308.git.lucien.xin@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCHv3 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xin Long , network dev , bridge@lists.linux-foundation.org Cc: davem@davemloft.net On 04/08/2016 06:03 PM, Xin Long wrote: > Now when we change the attributes of bridge or br_port by netlink, > a relevant netlink notification will be sent, but if we change them > by ioctl or sysfs, no notification will be sent. > > We should ensure that whenever those attributes change internally or from > sysfs/ioctl, that a netlink notification is sent out to listeners. > > Also, NetworkManager will use this in the future to listen for out-of-band > bridge master attribute updates and incorporate them into the runtime > configuration. > > This patch is used for br_sysfs_br. and we also need to remove some > rtnl_trylock in old functions so that we can call it in a common one. > > For group_addr_store, we cannot make it use store_bridge_parm, because > it's not a string-to-long convert, we will add notification on it > individually. > > Signed-off-by: Xin Long > --- > net/bridge/br_sysfs_br.c | 21 +++++++++------------ > net/bridge/br_vlan.c | 30 +++++------------------------- > 2 files changed, 14 insertions(+), 37 deletions(-) > Signed-off-by: Nikolay Aleksandrov