From: Florian Fainelli <f.fainelli@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, ast@kernel.org, daniel@iogearbox.net
Cc: andrew@lunn.ch, mustafa.ismail@intel.com,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
pablo@netfilter.org, andrii@kernel.org,
george.mccollister@gmail.com, anthony.l.nguyen@intel.com,
ralf@linux-mips.org, linux-hams@vger.kernel.org, hawk@kernel.org,
steffen.klassert@secunet.com, linux-s390@vger.kernel.org,
pkshih@realtek.com, herbert@gondor.apana.org.au, leon@kernel.org,
linux-bluetooth@vger.kernel.org, linux-rdma@vger.kernel.org,
bridge@lists.linux-foundation.org, john.fastabend@gmail.com,
jesse.brandeburg@intel.com, kadlec@netfilter.org, jgg@ziepe.ca,
dledford@redhat.com, coreteam@netfilter.org,
intel-wired-lan@lists.osuosl.org, nikolay@nvidia.com,
habetsm.xilinx@gmail.com, yzaikin@google.com,
vivien.didelot@gmail.com, wg@grandegger.com, sgarzare@redhat.com,
woojung.huh@microchip.com, johan.hedberg@gmail.com,
arnd@arndb.de, marcel@holtmann.org, jhs@mojatatu.com,
linux-can@vger.kernel.org, wenjia@linux.ibm.com,
Marc Kleine-Budde <mkl@pengutronix.de>,
viro@zeniv.linux.org.uk, luiz.dentz@gmail.com, jiri@nvidia.com,
xiyou.wangcong@gmail.com, michael.chan@broadcom.com,
virtualization@lists.linux-foundation.org,
shiraz.saleem@intel.com, trond.myklebust@hammerspace.com,
kvalo@codeaurora.org, linux-nfs@vger.kernel.org,
wintera@linux.ibm.com, keescook@chromium.org,
netdev@vger.kernel.org, dsahern@kernel.org,
linux-decnet-user@lists.sourceforge.net, fw@strlen.de,
tariqt@nvidia.com, kgraul@linux.ibm.com, ecree.xilinx@gmail.com,
mcgrof@kernel.org, netfilter-devel@vger.kernel.org,
jreuter@yaina.de, linux-fsdevel@vger.kernel.org,
bpf@vger.kernel.org, olteanv@gmail.com, saeedm@nvidia.com,
anna.schumaker@netapp.com, ap420073@gmail.com
Subject: Re: [Bridge] [PATCH bpf-next v2] net: don't include filter.h from net/sock.h
Date: Tue, 28 Dec 2021 17:33:39 -0800 [thread overview]
Message-ID: <5a82690c-7dc0-81de-4dd6-06e26e4b9b92@gmail.com> (raw)
In-Reply-To: <20211229004913.513372-1-kuba@kernel.org>
On 12/28/2021 4:49 PM, Jakub Kicinski wrote:
> sock.h is pretty heavily used (5k objects rebuilt on x86 after
> it's touched). We can drop the include of filter.h from it and
> add a forward declaration of struct sk_filter instead.
> This decreases the number of rebuilt objects when bpf.h
> is touched from ~5k to ~1k.
>
> There's a lot of missing includes this was masking. Primarily
> in networking tho, this time.
>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
It would be nice if we used the number of files rebuilt because of a
header file change as another metric that the kernel is evaluated with
from release to release (or even on a commit by commit basis). Food for
thought.
--
Florian
next prev parent reply other threads:[~2021-12-29 1:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 0:49 [Bridge] [PATCH bpf-next v2] net: don't include filter.h from net/sock.h Jakub Kicinski
2021-12-29 1:33 ` Florian Fainelli [this message]
2021-12-29 17:20 ` Jakub Kicinski
2022-01-04 15:42 ` Andy Shevchenko
2021-12-29 11:46 ` Nikolay Aleksandrov
2021-12-29 14:05 ` Stefano Garzarella
2021-12-29 16:51 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a82690c-7dc0-81de-4dd6-06e26e4b9b92@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=andrii@kernel.org \
--cc=anna.schumaker@netapp.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ap420073@gmail.com \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=bpf@vger.kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=dledford@redhat.com \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=fw@strlen.de \
--cc=george.mccollister@gmail.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hawk@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jgg@ziepe.ca \
--cc=jhs@mojatatu.com \
--cc=jiri@nvidia.com \
--cc=johan.hedberg@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=jreuter@yaina.de \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=leon@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mcgrof@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mkl@pengutronix.de \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=pablo@netfilter.org \
--cc=pkshih@realtek.com \
--cc=ralf@linux-mips.org \
--cc=saeedm@nvidia.com \
--cc=sgarzare@redhat.com \
--cc=shiraz.saleem@intel.com \
--cc=steffen.klassert@secunet.com \
--cc=tariqt@nvidia.com \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=vivien.didelot@gmail.com \
--cc=wenjia@linux.ibm.com \
--cc=wg@grandegger.com \
--cc=wintera@linux.ibm.com \
--cc=woojung.huh@microchip.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox