Ethernet Bridge development
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	horms@kernel.org, dsahern@kernel.org, pablo@netfilter.org,
	kadlec@netfilter.org, roopa@nvidia.com, razor@blackwall.org,
	gnault@redhat.com, bigeasy@linutronix.de, hawk@kernel.org,
	idosch@nvidia.com, dongml2@chinatelecom.cn,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	bridge@lists.linux.dev, bpf@vger.kernel.org
Subject: Re: [PATCH RESEND net-next v4 6/9] net: ip: make ip_route_input_noref() return drop reasons
Date: Tue, 5 Nov 2024 12:22:35 +0100	[thread overview]
Message-ID: <62773e8f-884c-4bfe-b412-97ad976f9cb8@redhat.com> (raw)
In-Reply-To: <20241030014145.1409628-7-dongml2@chinatelecom.cn>

Hi,

On 10/30/24 02:41, Menglong Dong wrote:
> @@ -175,10 +175,12 @@ static void ip_expire(struct timer_list *t)
>  
>  	/* skb has no dst, perform route lookup again */
>  	iph = ip_hdr(head);
> -	err = ip_route_input_noref(head, iph->daddr, iph->saddr, ip4h_dscp(iph),
> -				   head->dev);
> -	if (err)
> +	reason = ip_route_input_noref(head, iph->daddr, iph->saddr,
> +				      ip4h_dscp(iph), head->dev);
> +	if (reason)
>  		goto out;
> +	else
> +		reason = SKB_DROP_REASON_FRAG_REASM_TIMEOUT;

I think the else branch above is confusing - and unneeded.

Please move the assignment after the comment below, so it's clear why we
get a TIMEOUT drop reason.

Thanks,

Paolo


  reply	other threads:[~2024-11-05 11:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30  1:41 [PATCH RESEND net-next v4 0/9] net: ip: add drop reasons to input route Menglong Dong
2024-10-30  1:41 ` [PATCH RESEND net-next v4 1/9] net: ip: make fib_validate_source() support drop reasons Menglong Dong
2024-10-30  1:41 ` [PATCH RESEND net-next v4 2/9] net: ip: make ip_route_input_mc() return drop reason Menglong Dong
2024-10-30  1:41 ` [PATCH RESEND net-next v4 3/9] net: ip: make ip_mc_validate_source() " Menglong Dong
2024-10-30  1:41 ` [PATCH RESEND net-next v4 4/9] net: ip: make ip_route_input_slow() return drop reasons Menglong Dong
2024-10-30  1:41 ` [PATCH RESEND net-next v4 5/9] net: ip: make ip_route_input_rcu() " Menglong Dong
2024-10-30  1:41 ` [PATCH RESEND net-next v4 6/9] net: ip: make ip_route_input_noref() " Menglong Dong
2024-11-05 11:22   ` Paolo Abeni [this message]
2024-11-06  9:40     ` Menglong Dong
2024-10-30  1:41 ` [PATCH RESEND net-next v4 7/9] net: ip: make ip_route_input() " Menglong Dong
2024-10-30  1:41 ` [PATCH RESEND net-next v4 8/9] net: ip: make ip_mkroute_input/__mkroute_input " Menglong Dong
2024-11-05 11:25   ` Paolo Abeni
2024-11-06 11:58     ` Menglong Dong
2024-10-30  1:41 ` [PATCH RESEND net-next v4 9/9] net: ip: make ip_route_use_hint() " Menglong Dong
2024-11-05 11:28   ` Paolo Abeni
2024-11-06 11:59     ` Menglong Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62773e8f-884c-4bfe-b412-97ad976f9cb8@redhat.com \
    --to=pabeni@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=bridge@lists.linux.dev \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=dongml2@chinatelecom.cn \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=gnault@redhat.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menglong8.dong@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox