From: Taehee Yoo <ap420073@gmail.com>
To: Nikolay Aleksandrov <nikolay@nvidia.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: bridge@lists.linux-foundation.org, cong.wang@bytedance.com,
daniel@iogearbox.net, yoshfuji@linux-ipv6.org,
j.vosburgh@gmail.com, dsahern@kernel.org, roopa@nvidia.com,
ast@kernel.org, bjorn@kernel.org, vfalico@gmail.com,
netdev@vger.kernel.org, kuba@kernel.org, weiwan@google.com,
andriin@fb.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net 2/2] net: bridge: fix lockdep multicast_lock false positive splat
Date: Tue, 27 Apr 2021 00:17:52 +0900 [thread overview]
Message-ID: <68b18d15-d472-3305-4f91-5e61f8b60488@gmail.com> (raw)
In-Reply-To: <1e8cda49-4bc3-6f0b-29f3-97848aab18f0@nvidia.com>
On 4/26/21 10:15 PM, Nikolay Aleksandrov wrote:
> On 26/04/2021 15:48, Herbert Xu wrote:
Hi Nikolay and Herbert,
Thank you for the reviews!
>> On Sun, Apr 25, 2021 at 07:45:27PM +0300, Nikolay Aleksandrov wrote:
>>>
>>> Ugh.. that's just very ugly. :) The setup you've described above is
by all means invalid, but
>>> possible unfortunately. The bridge already checks if it's being
added as a port to another
>>> bridge, but not through multiple levels of indirection. These locks
are completely unrelated
>>> as they're in very different contexts (different devices).
>>
>> Surely we should forbid this? Otherwise what's to stop someone
>> from creating a loop?
>>
>> Cheers,
>>
>
> Indeed that would be best, it's very easy to loop them.
>
We can make very various interface graphs with master/slave interface types.
So, if we need something to forbid it, I think it should be generic
code, not only for the bridge module.
next prev parent reply other threads:[~2021-04-26 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 15:57 [Bridge] [PATCH net v2 0/2] net: fix lockdep false positive splat Taehee Yoo
2021-04-25 15:57 ` [Bridge] [PATCH net v2 1/2] net: core: make bond_get_lowest_level_rcu() generic Taehee Yoo
2021-04-25 18:03 ` Heiner Kallweit
2021-04-26 15:24 ` Taehee Yoo
2021-04-25 15:57 ` [Bridge] [PATCH net 2/2] net: bridge: fix lockdep multicast_lock false positive splat Taehee Yoo
2021-04-25 16:45 ` Nikolay Aleksandrov
2021-04-26 12:48 ` Herbert Xu
2021-04-26 13:15 ` Nikolay Aleksandrov
2021-04-26 15:17 ` Taehee Yoo [this message]
2021-04-26 15:39 ` Nikolay Aleksandrov
-- strict thread matches above, loose matches on Subject: below --
2021-04-25 15:52 [Bridge] [PATCH net 0/2] Subject: [PATCH net 0/2] net: fix lockdep " Taehee Yoo
2021-04-25 15:52 ` [Bridge] [PATCH net 2/2] net: bridge: fix lockdep multicast_lock " Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68b18d15-d472-3305-4f91-5e61f8b60488@gmail.com \
--to=ap420073@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
--cc=vfalico@gmail.com \
--cc=weiwan@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox