From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2E0BF60F49 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 169D460E5D MIME-Version: 1.0 Date: Mon, 29 Aug 2022 17:08:23 +0200 From: netdev@kapio-technology.com In-Reply-To: References: <20220826114538.705433-1-netdev@kapio-technology.com> <20220826114538.705433-7-netdev@kapio-technology.com> <7654860e4d7d43c15d482c6caeb6a773@kapio-technology.com> <2967ccc234bb672f5440a4b175b73768@kapio-technology.com> <9e1a9eb218bbaa0d36cb98ff5d4b97d7@kapio-technology.com> Message-ID: <69db7606896c77924c11a6c175c4b1a6@kapio-technology.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ido Schimmel Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , linux-kselftest@vger.kernel.org, Shuah Khan , Ivan Vecera , Florian Fainelli , Daniel Borkmann , bridge@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, Roopa Prabhu , kuba@kernel.org, Paolo Abeni , Vivien Didelot , Woojung Huh , Landen Chao , Jiri Pirko , Christian Marangi , Hauke Mehrtens , Sean Wang , DENG Qingfang , Claudiu Manoil , linux-mediatek@lists.infradead.org, Matthias Brugger , Yuwei Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Vladimir Oltean , davem@davemloft.net On 2022-08-29 16:37, Ido Schimmel wrote: > On Mon, Aug 29, 2022 at 02:04:42PM +0200, netdev@kapio-technology.com > wrote: >> On 2022-08-29 13:32, Ido Schimmel wrote: >> Port association is needed for MAB to work at all on mv88e6xxx, but >> for >> 802.1X port association is only needed for dynamic ATU entries. > > Ageing of dynamic entries in the bridge requires learning to be on as > well, but in these test cases you are only using static entries and > there is no reason to enable learning in the bridge for that. I prefer > not to leak this mv88e6xxx implementation detail to user space and > instead have the driver enable port association based on whether > "learning" or "mab" is on. > Then it makes most sense to have the mv88e6xxx driver enable port association when then port is locked, as it does now.