From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 85A914018E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6D38F40002 MIME-Version: 1.0 Date: Sun, 23 Oct 2022 07:32:02 +0200 From: netdev@kapio-technology.com In-Reply-To: References: <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-3-netdev@kapio-technology.com> Message-ID: <7690b7f836b144b60f60b3b68d3bf784@kapio-technology.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v8 net-next 02/12] net: bridge: add blackhole fdb entry flag List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ido Schimmel Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , linux-kselftest@vger.kernel.org, Joachim Wiberg , Shuah Khan , Ivan Vecera , Florian Fainelli , Daniel Borkmann , Florent Fourcot , bridge@lists.linux-foundation.org, Russell King , linux-arm-kernel@lists.infradead.org, Roopa Prabhu , kuba@kernel.org, Paolo Abeni , Vivien Didelot , Woojung Huh , Landen Chao , Jiri Pirko , Amit Cohen , Christian Marangi , Hauke Mehrtens , Hans Schultz , Sean Wang , DENG Qingfang , Claudiu Manoil , linux-mediatek@lists.infradead.org, Matthias Brugger , Yuwei Wang , Petr Machata , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Vladimir Oltean , davem@davemloft.net On 2022-10-20 15:06, Ido Schimmel wrote: > [...] > >> @@ -1140,7 +1148,7 @@ static int __br_fdb_add(struct ndmsg *ndm, >> struct net_bridge *br, >> err = br_fdb_external_learn_add(br, p, addr, vid, true); >> } else { >> spin_lock_bh(&br->hash_lock); >> - err = fdb_add_entry(br, p, addr, ndm, nlh_flags, vid, nfea_tb); >> + err = fdb_add_entry(br, p, addr, ndm, nlh_flags, vid, ext_flags, >> nfea_tb); > > I believe the preference is to wrap to 80 columns when possible. Very strange... since I ran checkpatch.pl from the net-next kernel itself and it did not give me any warnings about 80 columns, but rather said 'patch is ready for submission'. As this is silent, could it be some missing python plugins or something to do with perl?