Re: [PATCH net-next] net: bridge: bound the port VLAN lists in the IFLA_AF_SPEC nest

[Nikolay Aleksandrov <razor@blackwall.org>]

On 07/09/2026 16:35, Artem Lytkin wrote:
> On Mon, Sep 07, 2026 at 11:47:24AM +0300, Nikolay Aleksandrov wrote:
>> I prefer a more explicit path - return error for both (RTM_GETLINK and notifications)
>> you'll have to plumb down extack but then user-space will know there are too many objects or lost
>> RTNL_LINK notifications and it should resync (e.g. use RTM_GETVLAN to dump the vlans if needed).
> 
> OK, v2 will do that: br_fill_ifinfo() fails with -E2BIG once the nest
> would pass 65535, kept distinct from -EMSGSIZE so the WARN_ON in
> br_info_notify() still means what it means today and the error goes to
> rtnl_set_sk_err(). For the dump, rtnl_bridge_getlink() can turn -E2BIG
> into the extack message itself, which keeps ndo_bridge_getlink() as it
> is; or do you want extack plumbed through the ndo? The size clamp and
> the doc text go away.
> 
> Artem

I'd prefer to plumb down the extack so the bridge can set it itself and be specific
if needed. Others might want to fill it with something different, there are only
a few drivers that implement it and some may decide to return user-friendly errors.
Please make sure to split the patches well, don't do everything in a single patch.

Thanks,
  Nik