From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8D94198A08 for ; Fri, 7 Feb 2025 20:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738958674; cv=none; b=gb2EujPkSeqZ03UHIamQKebHBQ2cDGZDUteObxbuG3h1T3U+YtovIWUv/ShE+iql8p42HLQCRu1BLTt72CAmqrYNiiQGax7U3w26YJi+3dI+diycxn1+2uyLh1Tk438XRhHUTadza+x+//u3SbPBYrKlLLbeXg1yrNcWw0QWsD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738958674; c=relaxed/simple; bh=c0HE3fhR5sqsIIunJnpVU2sofmoEc9yrKyaRzinguC8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=grBGPYP5L4ptu6S1luAtH6TR72Oh1g/nWRocd4i+nSq1D+ka96efmbnGgJvhQ39YmdE0V/TlepLySzFztaGpJPmQGS6uw4XsX+eSXKAVSL5Bfr+0JxIbnJAdkncTDBMdk6AOXsY9ORxk6mCvChcTwTIq2WUylU7IEb6EOjXek8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eoZqTbOK; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eoZqTbOK" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5de4a8b4f86so1600073a12.2 for ; Fri, 07 Feb 2025 12:04:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738958671; x=1739563471; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G2tTSDZ2XD8g2DNn6kyimdWtnPTRpKW0MbS5kEtAlX8=; b=eoZqTbOK00tGlTNqlPemNeAUfwPKJ7MOQxv6gSPW4ng+Q9SQP+7BE4QEmCAewuzGep lHTiLbTtNq8uD2BbBZBbhmTATnLkcS8A7LUA8dWTKB/E9Mcv5aUauo+4tvPqruw61Hdf f9zeAotG1Km/wgvvh92TTYsiI2PJElpw/YGGuWJZxwamo2Di3fF+YROEIZyHz5rROT2I 31LOIOJJuTh/CaXmsb6BT33tmXAz5X+9F4N2BjKxsxt23TqJQunUmX7gF49eZyDKMvtK KMUHHntMChywV1mhVXWNMtcYxdAiAw2RmsovzbY7e2xqsxvh0ujejOgnImmeBGa8w/4h XIkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738958671; x=1739563471; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G2tTSDZ2XD8g2DNn6kyimdWtnPTRpKW0MbS5kEtAlX8=; b=u++15dnr37n2D4pu1/9Mdve2u1uocpitIogPoJuzTJrRdbwuFYlDU1815VYnD0zFqD mBSfHN342dugew+bSthjZaXbnt7ihv4RNLHvfMFCRnZqJB3hhLD1ZjyYWE6fy6l2VFmq 0TTUVxtyFmX+XJszGi3TWlYEWC59BjyjDOUJdqXmWFu3hpvqUbngy6rr4B4cmUymmZd2 BxTxeHkxFE0Ohid1/gOgklwBYxjN8nnCAi0IePzS5Wk1tb7/l7mG7dqQDCv/mIvXpaGD oDCWJjYBcTyjpGEprGcW8cQGrq9aHZ8bMsGDseeKkh8PkQB+9yTID17u83JRWPVUFpj3 LwEA== X-Forwarded-Encrypted: i=1; AJvYcCUxCUZAKOjCO7JYgbXTwFO+lwGSul38vuwFcW3KNuME+yBmqo06DeqsL53R1EXWtOXDsFf7Ffk=@lists.linux.dev X-Gm-Message-State: AOJu0YzZVnQ2XpPMuHoUcJQSand3hal8EemEuqMQRVHCFx/44AHBKAWq 7ovseUWFQM10WWdOOVHas7YBHbgI8CrnMZGdQsw09guCylml1Yo/ X-Gm-Gg: ASbGncu4j13xCa6sDgLRCUPElGbFdlIvAHDhgmCOPo8PEIMa7+egHDWgzxqVK3HRZuT e0bvLgS8Pwyhehg1NrZFt6YwXSjCdkgkn+kdMamro5YdngPvWT/NA2JnJJf7U9VEQ3viXcREbMG 9eoNIsJWd8vJEyEalm0jLzYowthR9VMLKwUzik9+hRvZl/fqhmediovZJ/nA8jmq7Aef+oaUaba G6vjwDjh0AOushTiuhc5QagpizjaQxOouKkkaiF5p+0REpmQFqotB6Qj0xMF9+nB4E1FEZeukZN cvVaYKTr6DAclUOI9RQb1Phz0WarTXfw0ESUCZItoUqfuudRLPVfuMhYNIQ+W5zoSH8nTUkeqPJ Fnrozv124XZI6Nxwcieo94L3Da9W+WUjHWGNlQ23jM2QP9zaCRbenP4LQhRL9ClMpOQ== X-Google-Smtp-Source: AGHT+IFwhFFxWKhiLiV5wk2B71s8k88eNWyrwlatwlmZhNRtZGKXQn0gb2lgnlR7Mo2Je7BPaqOlyA== X-Received: by 2002:a05:6402:2383:b0:5dc:7fbe:7313 with SMTP id 4fb4d7f45d1cf-5de44feb7bfmr6015830a12.6.1738958670962; Fri, 07 Feb 2025 12:04:30 -0800 (PST) Received: from ?IPV6:2001:1c00:20d:1300:1b1c:4449:176a:89ea? (2001-1c00-020d-1300-1b1c-4449-176a-89ea.cable.dynamic.v6.ziggo.nl. [2001:1c00:20d:1300:1b1c:4449:176a:89ea]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5de39feff59sm2298672a12.77.2025.02.07.12.04.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Feb 2025 12:04:30 -0800 (PST) Message-ID: <78a30eab-cae6-4026-b701-7d7002fe3abb@gmail.com> Date: Fri, 7 Feb 2025 21:04:28 +0100 Precedence: bulk X-Mailing-List: bridge@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 net-next 12/14] bridge: No DEV_PATH_BR_VLAN_UNTAG_HW for dsa foreign To: Vladimir Oltean Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Pablo Neira Ayuso , Jozsef Kadlecsik , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Matthias Brugger , AngeloGioacchino Del Regno , Kuniyuki Iwashima , Sebastian Andrzej Siewior , Lorenzo Bianconi , Joe Damato , Alexander Lobakin , Frank Wunderlich , Daniel Golle , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20250204194921.46692-1-ericwouds@gmail.com> <20250204194921.46692-13-ericwouds@gmail.com> <20250207150340.sxhsva7qz7bb7qjd@skbuf> From: Eric Woudstra Content-Language: en-US In-Reply-To: <20250207150340.sxhsva7qz7bb7qjd@skbuf> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/7/25 4:03 PM, Vladimir Oltean wrote: > On Tue, Feb 04, 2025 at 08:49:19PM +0100, Eric Woudstra wrote: >> In network setup as below: >> >> fastpath bypass >> .----------------------------------------. >> / \ >> | IP - forwarding | >> | / \ v >> | / wan ... >> | / >> | | >> | | >> | brlan.1 >> | | >> | +-------------------------------+ >> | | vlan 1 | >> | | | >> | | brlan (vlan-filtering) | >> | | +---------------+ >> | | | DSA-SWITCH | >> | | vlan 1 | | >> | | to | | >> | | untagged 1 vlan 1 | >> | +---------------+---------------+ >> . / \ >> ----->wlan1 lan0 >> . . >> . ^ >> ^ vlan 1 tagged packets >> untagged packets >> >> br_vlan_fill_forward_path_mode() sets DEV_PATH_BR_VLAN_UNTAG_HW when >> filling in from brlan.1 towards wlan1. But it should be set to >> DEV_PATH_BR_VLAN_UNTAG in this case. Using BR_VLFLAG_ADDED_BY_SWITCHDEV >> is not correct. The dsa switchdev adds it as a foreign port. >> >> The same problem for all foreignly added dsa vlans on the bridge. >> >> First add the vlan, trying only native devices. >> If this fails, we know this may be a vlan from a foreign device. >> >> Use BR_VLFLAG_TAGGING_BY_SWITCHDEV to make sure DEV_PATH_BR_VLAN_UNTAG_HW >> is set only when there if no foreign device involved. >> >> Signed-off-by: Eric Woudstra >> --- > > Shouldn't mlxsw_sp_switchdev_vxlan_vlans_add() also respect the > SWITCHDEV_F_NO_FOREIGN flag? My (maybe incorrect) understanding of > bridging topologies with vxlan and mlxsw is that they are neighbor > bridge ports, and mlxsw doesn't (seem to) call > switchdev_bridge_port_offload() for the vxlan bridge port. This > technically makes vxlan a foreign bridge port to mlxsw, so it should > skip reacting on VLAN switchdev objects when that flag is set, just > for uniform behavior across the board. > > (your patch repeats the notifier without the SWITCHDEV_F_NO_FOREIGN > flag anyway, so it only matters for flowtable offload). Or should mlxsw_sp_switchdev_blocking_event() use switchdev_handle_port_obj_add_foreign() to add the vxlan foreign port? Then all foreign ports are added in a uniform manner and SWITCHDEV_F_NO_FOREIGN is respected. I do not have the hardware to test any changes in that code.