From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org C21B740541 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org D6B49404B2 MIME-Version: 1.0 Date: Wed, 28 Sep 2022 12:16:21 +0200 From: netdev@kapio-technology.com In-Reply-To: References: <20220908112044.czjh3xkzb4r27ohq@skbuf> <152c0ceadefbd742331c340bec2f50c0@kapio-technology.com> <20220911001346.qno33l47i6nvgiwy@skbuf> <15ee472a68beca4a151118179da5e663@kapio-technology.com> <086704ce7f323cc1b3cca78670b42095@kapio-technology.com> <7a4549d645f9bbbf41e814f087eb07d1@kapio-technology.com> <0c6b93c828d9b52346ddb3d445446734@kapio-technology.com> Message-ID: <7a1683c86e02305e90f7b1ceaaabdabe@kapio-technology.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ido Schimmel Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , linux-kselftest@vger.kernel.org, Shuah Khan , Ivan Vecera , Florian Fainelli , Daniel Borkmann , bridge@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, Roopa Prabhu , kuba@kernel.org, Paolo Abeni , Vivien Didelot , Woojung Huh , Landen Chao , Jiri Pirko , Christian Marangi , Hauke Mehrtens , Sean Wang , DENG Qingfang , Claudiu Manoil , linux-mediatek@lists.infradead.org, Matthias Brugger , Yuwei Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Vladimir Oltean , davem@davemloft.net On 2022-09-28 10:46, Ido Schimmel wrote: > On Wed, Sep 28, 2022 at 09:47:42AM +0200, netdev@kapio-technology.com > wrote: > It needs "master" keyword: > I must have forgotten it when I tested at some point... It seems to be working, only that I am at a loss to why port_fdb_add() is called for each port after going through the DSA layer. I understand that all slave devices are listening on events, but I think the ops should only be called when the port matches? Also for some reason the blackhole (zero-DPV) ATU entry is not added on my device in case of no vlan (vid = 0), but there is also some phy problems that are unrelated to this patch set.