From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 877B541FB8 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org D7E6F41FAF From: Hans Schultz In-Reply-To: <20230330192714.oqosvifrftirshej@skbuf> References: <20230318141010.513424-1-netdev@kapio-technology.com> <20230318141010.513424-7-netdev@kapio-technology.com> <87a5zzh65p.fsf@kapio-technology.com> <874jq22h2u.fsf@kapio-technology.com> <20230330192714.oqosvifrftirshej@skbuf> Date: Fri, 31 Mar 2023 10:06:34 +0200 Message-ID: <871ql5mjjp.fsf@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Bridge] [PATCH v2 net-next 6/6] selftests: forwarding: add dynamic FDB test List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Oltean Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , open list , Eric Dumazet , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan , Ivan Vecera , Florian Fainelli , "moderated list:ETHERNET BRIDGE" , Ido Schimmel , kuba@kernel.org, Paolo Abeni , =?utf-8?Q?Cl=C3=A9ment_L=C3=A9ger?= , Christian Marangi , Woojung Huh , Landen Chao , Jiri Pirko , Hauke Mehrtens , Sean Wang , DENG Qingfang , Claudiu Manoil , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , AngeloGioacchino Del Regno , netdev@vger.kernel.org, Roopa Prabhu , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , davem@davemloft.net On Thu, Mar 30, 2023 at 22:27, Vladimir Oltean wrote: > On Thu, Mar 30, 2023 at 09:07:53PM +0200, Hans Schultz wrote: >> Not true, it reveals that I forgot to put it in the patch, that's all. As >> I cannot run several of these tests because of memory constraints I link >> the file to a copy in a rw area where I modify the list and just run one >> of the subtests at a time. If I try to run the whole it always fails >> after a couple of sub-tests with an error. >> >> It seems to me that these scripts are quite memory consuming as they >> accumulate memory consuption in relation to what is loaded along the >> way. A major problem with my system. > > I'm sorry for perhaps asking something entirely obvious, but have you tried: > > kernel-dir $ rsync -avr tools/testing/selftests/ root@$board:selftests/ > board $ cd selftests/drivers/net/dsa/ > board $ ./bridge_locked_port.sh lan0 lan1 lan2 lan3 > > ? > > This is how I always run them, and it worked fine with both Debian > (where it's easy to add missing packages to the rootfs) or with a more > embedded-oriented Buildroot. The memory problems are of course on the embedded target. In that case I think it would be a very good idea to do something to design the system better, so that it frees memory between the subtests. If all tests are always run on the bridge only, I think they don't make much sense as these patchsets are directed towards switchcores.