From: Petr Machata <petrm@nvidia.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Petr Machata <petrm@nvidia.com>,
netdev@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>,
bridge@lists.linux-foundation.org,
Ido Schimmel <idosch@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
Roopa Prabhu <roopa@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
linux-trace-kernel@vger.kernel.org
Subject: Re: [Bridge] [PATCH net-next 06/16] net: bridge: Add a tracepoint for MDB overflows
Date: Mon, 30 Jan 2023 16:50:32 +0100 [thread overview]
Message-ID: <87ilgof20x.fsf@nvidia.com> (raw)
In-Reply-To: <20230126125344.1b7b34e2@gandalf.local.home>
Steven Rostedt <rostedt@goodmis.org> writes:
> On Thu, 26 Jan 2023 18:01:14 +0100
> Petr Machata <petrm@nvidia.com> wrote:
>
>> + TP_printk("dev %s af %u src %pI4/%pI6c grp %pI4/%pI6c/%pM vid %u",
>> + __get_str(dev), __entry->af, __entry->src4, __entry->src6,
>> + __entry->grp4, __entry->grp6, __entry->grpmac, __entry->vid)
>
> And just have:
>
> TP_printk("dev %s af %u src %pI6c grp %pI6c/%pM vid %u",
> __get_str(dev), __entry->af, __entry->src, __entry->grp,
> __entry->grpmac, __entry->vid)
>
> As the %pI6c should detect that it's a ipv4 address and show that.
This means the IP addresses will always be IPv6, even for an IPv4 MDB
entries. One can still figure out the true protocol from the address
family field, but it might not be obvious. Plus the IPv4-mapped IPv6
addresses are not really formatted as IPv4, though yeah, IPv4 notation
is embedded in that.
All the information is still there, but... scrambled? Not sure the
reduction in clarity is worth the 8 bytes that we save. The tracepoint
is unlikely to trigger often.
What say you?
next prev parent reply other threads:[~2023-01-30 15:50 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 17:01 [Bridge] [PATCH net-next 00/16] bridge: Limit number of MDB entries per port, port-vlan Petr Machata
2023-01-26 17:01 ` [Bridge] [PATCH net-next 01/16] net: bridge: Set strict_start_type at two policies Petr Machata
2023-01-26 19:18 ` Stephen Hemminger
2023-01-26 20:27 ` Nikolay Aleksandrov
2023-01-29 9:09 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 02/16] net: bridge: Add extack to br_multicast_new_port_group() Petr Machata
2023-01-29 9:09 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 03/16] net: bridge: Move extack-setting " Petr Machata
2023-01-29 9:09 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 04/16] net: bridge: Add br_multicast_del_port_group() Petr Machata
2023-01-29 9:11 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 05/16] net: bridge: Change a cleanup in br_multicast_new_port_group() to goto Petr Machata
2023-01-29 9:11 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 06/16] net: bridge: Add a tracepoint for MDB overflows Petr Machata
2023-01-26 17:53 ` Steven Rostedt
2023-01-27 14:29 ` Petr Machata
2023-01-30 15:50 ` Petr Machata [this message]
2023-01-30 23:23 ` Steven Rostedt
2023-01-26 17:01 ` [Bridge] [PATCH net-next 07/16] net: bridge: Maintain number of MDB entries in net_bridge_mcast_port Petr Machata
2023-01-29 9:40 ` Nikolay Aleksandrov
2023-01-29 16:55 ` Nikolay Aleksandrov
2023-01-30 8:08 ` Ido Schimmel
2023-01-30 8:56 ` Nikolay Aleksandrov
2023-01-30 15:02 ` Petr Machata
2023-01-26 17:01 ` [Bridge] [PATCH net-next 08/16] net: bridge: Add netlink knobs for number / maximum MDB entries Petr Machata
2023-01-29 10:07 ` Nikolay Aleksandrov
2023-01-29 14:58 ` Ido Schimmel
2023-01-30 11:07 ` Petr Machata
2023-01-26 17:01 ` [Bridge] [PATCH net-next 09/16] selftests: forwarding: Move IGMP- and MLD-related functions to lib Petr Machata
2023-01-29 10:08 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 10/16] selftests: forwarding: bridge_mdb: Fix a typo Petr Machata
2023-01-29 10:09 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 11/16] selftests: forwarding: lib: Add helpers for IP address handling Petr Machata
2023-01-29 10:09 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 12/16] selftests: forwarding: lib: Add helpers for checksum handling Petr Machata
2023-01-29 10:10 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 13/16] selftests: forwarding: lib: Parameterize IGMPv3/MLDv2 generation Petr Machata
2023-01-29 10:10 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 14/16] selftests: forwarding: lib: Allow list of IPs for IGMPv3/MLDv2 Petr Machata
2023-01-29 10:11 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 15/16] selftests: forwarding: lib: Add helpers to build IGMP/MLD leave packets Petr Machata
2023-01-29 10:11 ` Nikolay Aleksandrov
2023-01-26 17:01 ` [Bridge] [PATCH net-next 16/16] selftests: forwarding: bridge_mdb_max: Add a new selftest Petr Machata
2023-01-29 10:12 ` Nikolay Aleksandrov
2023-01-26 20:28 ` [Bridge] [PATCH net-next 00/16] bridge: Limit number of MDB entries per port, port-vlan Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilgof20x.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox