From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org F3FD841D7B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4917F418E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687346281; x=1718882281; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=bNOOeYVCQ7poh+/POpUoy8h5Fc7oKKTV5NlBm31y8T8=; b=HLDgmo/Az6NkgE+D6yL5JMGr2Pp1WVOXbzcdpTFcOQWQMf1scnfKLRsK qcM0pd7y57FmT0H91DPqWk/q3XD7rX73oC4LMk6bQoLGXYxSMfup3x+4N u+WxV2MaqV3ul8KHLuA9plVHlezkS4MxGbiBl56QdBEOxmpsWBotktuca 1xdZUEokxzpOa1y613kxEP3qDv8IBNz03kQMGCsX5X+kKPRaDc8gVBYhs +S035kDarl9rPtjkZEcerIWYUyk2WSAqBMihZ6zJ/jOZbz7HwjJi8AZ7S C5jtYbzTsaaZjtqBaFJpsTIWQ8LaVFEIU8hI731ciYI0TuD88/0uS6qjA Q==; From: Jani Nikula In-Reply-To: <20230621094817.433842-1-j.granados@samsung.com> References: <20230621091000.424843-1-j.granados@samsung.com> <20230621094817.433842-1-j.granados@samsung.com> Date: Wed, 21 Jun 2023 14:16:55 +0300 Message-ID: <87o7l92hg8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Bridge] [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joel Granados , mcgrof@kernel.org, Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Gerald Schaefer , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Herbert Xu , "David S. Miller" , Russ Weight , Greg Kroah-Hartman , Phillip Potter , Clemens Ladisch , Arnd Bergmann , Corey Minyard , Theodore Ts'o , "Jason A. Donenfeld" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jason Gunthorpe , Leon Romanovsky , Benjamin Herrenschmidt , Song Liu , Robin Holt , Steve Wahl , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sudip Mukherjee , Mark Rutland , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , Jiri Slaby , Juergen Gross , Stefano Stabellini , Alexander Viro , Christian Brauner , Benjamin LaHaise , David Howells , Jan Harkes , coda@cs.cmu.edu, Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Jan Kara , Anton Altaparmakov , Mark Fasheh , Joel Becker , Joseph Qi , Kees Cook , Iurii Zaikin , Eric Biggers , "Darrick J. Wong" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , Masami Hiramatsu , Peter Zijlstra , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , John Stultz , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , Joerg Reuter , Ralf Baechle , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , Alexander Aring , Stefan Schmidt , Miquel Raynal , Steffen Klassert , Matthieu Baerts , Mat Martineau , Simon Horman , Julian Anastasov , Remi Denis-Courmont , Santosh Shilimkar , Marc Dionne , Neil Horman , Marcelo Ricardo Leitner , Xin Long , Karsten Graul , Wenjia Zhang , Jan Karcher , Jon Maloy , Ying Xue , Martin Schiller , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Jarkko Sakkinen Cc: Joel Granados , Miaohe Lin , linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, "Rafael J. Wysocki" , linux-aio@kvack.org, Amir Goldstein , mptcp@lists.linux.dev, KP Singh , dri-devel@lists.freedesktop.org, Ben Segall , linux-mm@kvack.org, linux-sctp@vger.kernel.org, keyrings@vger.kernel.org, Stanislav Fomichev , "H. Peter Anvin" , linux-afs@lists.infradead.org, linux-s390@vger.kernel.org, Valentin Schneider , xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, dccp@vger.kernel.org, linux-rdma@vger.kernel.org, bridge@lists.linux-foundation.org, John Fastabend , linux-ntfs-dev@lists.sourceforge.net, Christophe Leroy , codalist@coda.cs.cmu.edu, lvs-devel@vger.kernel.org, Matthew Bobrowski , linux-cachefs@redhat.com, Mel Gorman , tipc-discussion@lists.sourceforge.net, Yonghong Song , Christian Borntraeger , intel-gfx@lists.freedesktop.org, linux-crypto@vger.kernel.org, linux-wpan@vger.kernel.org, coreteam@netfilter.org, John Ogness , Mike Travis , Boqun Feng , apparmor@lists.ubuntu.com, linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , rds-devel@oss.oracle.com, linux-raid@vger.kernel.org, Waiman Long , linux-hams@vger.kernel.org, openipmi-developer@lists.sourceforge.net, Dietmar Eggemann , linux-arm-kernel@lists.infradead.org, fsverity@lists.linux.dev, Hao Luo , linux-nfs@vger.kernel.org, Will Drewry , linux-x25@vger.kernel.org, Stephen Boyd , Daniel Bristot de Oliveira , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Lutomirski , linux-xfs@vger.kernel.org, Oleksandr Tyshchenko , linux-security-module@vger.kernel.org, netfilter-devel@vger.kernel.org, Sven Schnelle , Jiri Olsa , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Martin KaFai Lau , ocfs2-devel@oss.oracle.com On Wed, 21 Jun 2023, Joel Granados wrote: > Remove the empty end element from all the arrays that are passed to the > register sysctl calls. In some files this means reducing the explicit > array size by one. Also make sure that we are using the size in > ctl_table_header instead of evaluating the .procname element. Where's the harm in removing the end elements driver by driver? This is an unwieldy patch to handle. > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index f43950219ffc..e4d7372afb10 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4884,24 +4884,23 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data, > > static struct ctl_table oa_table[] = { > { > - .procname = "perf_stream_paranoid", > - .data = &i915_perf_stream_paranoid, > - .maxlen = sizeof(i915_perf_stream_paranoid), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = SYSCTL_ONE, > - }, > + .procname = "perf_stream_paranoid", > + .data = &i915_perf_stream_paranoid, > + .maxlen = sizeof(i915_perf_stream_paranoid), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > { > - .procname = "oa_max_sample_rate", > - .data = &i915_oa_max_sample_rate, > - .maxlen = sizeof(i915_oa_max_sample_rate), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - .extra2 = &oa_sample_rate_hard_limit, > - }, > - {} > + .procname = "oa_max_sample_rate", > + .data = &i915_oa_max_sample_rate, > + .maxlen = sizeof(i915_oa_max_sample_rate), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = &oa_sample_rate_hard_limit, > + } > }; The existing indentation is off, but fixing it doesn't really belong in this patch. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center